-
Notifications
You must be signed in to change notification settings - Fork 51
Place geojson schema at right place #711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -12,7 +12,7 @@ | |||
"data": { | |||
"type": "object", | |||
"description": "The GeoJSON data", | |||
"$ref": "./geojson.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should still be "./geojson.json" since it's located next to it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You were right using "./project/sources/geojson.json" it seems, because we use cwd
as ./src/schema
in here https://github.com/geojupyter/jupytergis/blob/main/packages/schema/package.json#L30
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it seems datamodel-codegen
prefers "$ref": "./geojson.json"
, which, to be fair, makes more sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dude 😓 "$ref": "./geojson.json"
is the correct approach IMO. datamodel-codegen
agrees.
But json2ts does not like that bcherny/json-schema-to-typescript#324
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see another place that needs to be changed?
import * as geojson from '@jupytergis/schema/src/schema/geojson.json'; |
Description
#710
Checklist
Resolves #XXX
.Failing lint checks can be resolved with:
pre-commit run --all-files
jlpm run lint
📚 Documentation preview: https://jupytergis--711.org.readthedocs.build/en/711/
💡 JupyterLite preview: https://jupytergis--711.org.readthedocs.build/en/711/lite