Skip to content

Making Embedded side panels Draggable. #957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+118 −99
Open

Making Embedded side panels Draggable. #957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f27d404
Making Embedded side panels Draggable.
nakul-py Oct 15, 2025
140502b
installing file again
nakul-py Oct 18, 2025
54144e8
discarding lockfile changes
nakul-py Oct 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@
"lerna": "^8.1.9",
"npm-run-all": "^4.1.5",
"prettier": "^3.0.0",
"react-draggable": "^4.5.0",
"rimraf": "^3.0.2",
"typescript": "^5",
"webpack": "^5.76.3"
Expand Down
95 changes: 49 additions & 46 deletions packages/base/src/panelview/leftpanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { IStateDB } from '@jupyterlab/statedb';
import { CommandRegistry } from '@lumino/commands';
import { MouseEvent as ReactMouseEvent } from 'react';
import * as React from 'react';
import Draggable from 'react-draggable';

import { LayersBodyComponent } from './components/layers';
import {
Expand Down Expand Up @@ -63,54 +64,56 @@ export const LeftPanel: React.FC<ILeftPanelProps> = (
);

return (
<div
className="jgis-left-panel-container"
style={{ display: leftPanelVisible ? 'block' : 'none' }}
>
<PanelTabs curTab={curTab} className="jgis-panel-tabs">
<TabsList>
{tabInfo.map(e => (
<TabsTrigger
className="jGIS-layer-browser-category"
value={e.name}
onClick={() => {
if (curTab !== e.name) {
setCurTab(e.name);
} else {
setCurTab('');
}
}}
>
{e.title}
</TabsTrigger>
))}
</TabsList>
<Draggable handle=".jgis-panel-tabs" bounds=".jGIS-Mainview-Container">
<div
className="jgis-left-panel-container"
style={{ display: leftPanelVisible ? 'block' : 'none' }}
>
<PanelTabs curTab={curTab} className="jgis-panel-tabs">
<TabsList>
{tabInfo.map(e => (
<TabsTrigger
className="jGIS-layer-browser-category"
value={e.name}
onClick={() => {
if (curTab !== e.name) {
setCurTab(e.name);
} else {
setCurTab('');
}
}}
>
{e.title}
</TabsTrigger>
))}
</TabsList>

{!settings.layersDisabled && (
<TabsContent
value="layers"
className="jgis-panel-tab-content jp-gis-layerPanel"
>
<LayersBodyComponent
model={props.model}
commands={props.commands}
state={props.state}
></LayersBodyComponent>
</TabsContent>
)}
{!settings.layersDisabled && (
<TabsContent
value="layers"
className="jgis-panel-tab-content jp-gis-layerPanel"
>
<LayersBodyComponent
model={props.model}
commands={props.commands}
state={props.state}
></LayersBodyComponent>
</TabsContent>
)}

{!settings.stacBrowserDisabled && (
<TabsContent value="stac" className="jgis-panel-tab-content">
<StacPanel model={props.model} />
</TabsContent>
)}
{!settings.stacBrowserDisabled && (
<TabsContent value="stac" className="jgis-panel-tab-content">
<StacPanel model={props.model} />
</TabsContent>
)}

{!settings.filtersDisabled && (
<TabsContent value="filters" className="jgis-panel-tab-content">
<FilterComponent model={props.model}></FilterComponent>
</TabsContent>
)}
</PanelTabs>
</div>
{!settings.filtersDisabled && (
<TabsContent value="filters" className="jgis-panel-tab-content">
<FilterComponent model={props.model}></FilterComponent>
</TabsContent>
)}
</PanelTabs>
</div>
</Draggable>
);
};
110 changes: 58 additions & 52 deletions packages/base/src/panelview/rightpanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import {
IJupyterGISModel,
} from '@jupytergis/schema';
import * as React from 'react';
import Draggable from 'react-draggable';

import { AnnotationsPanel } from './annotationPanel';
import { IdentifyPanelComponent } from './components/identify-panel/IdentifyPanel';
Expand Down Expand Up @@ -83,60 +84,65 @@ export const RightPanel: React.FC<IRightPanelProps> = props => {
React.useState(undefined);

return (
<div
className="jgis-right-panel-container"
style={{ display: rightPanelVisible ? 'block' : 'none' }}
>
<PanelTabs className="jgis-panel-tabs" curTab={curTab}>
<TabsList>
{tabInfo.map(e => (
<TabsTrigger
className="jGIS-layer-browser-category"
value={e.name}
onClick={() => {
if (curTab !== e.name) {
setCurTab(e.name);
} else {
setCurTab('');
}
}}
>
{e.title}
</TabsTrigger>
))}
</TabsList>
<Draggable handle=".jgis-panel-tabs" bounds=".jGIS-Mainview-Container">
<div
className="jgis-right-panel-container"
style={{ display: rightPanelVisible ? 'block' : 'none' }}
>
<PanelTabs className="jgis-panel-tabs" curTab={curTab}>
<TabsList>
{tabInfo.map(e => (
<TabsTrigger
className="jGIS-layer-browser-category"
value={e.name}
onClick={() => {
if (curTab !== e.name) {
setCurTab(e.name);
} else {
setCurTab('');
}
}}
>
{e.title}
</TabsTrigger>
))}
</TabsList>

{!settings.objectPropertiesDisabled && (
<TabsContent
value="objectProperties"
className="jgis-panel-tab-content"
>
<ObjectPropertiesReact
setSelectedObject={setSelectedObjectProperties}
selectedObject={selectedObjectProperties}
formSchemaRegistry={props.formSchemaRegistry}
model={props.model}
/>
</TabsContent>
)}
{!settings.objectPropertiesDisabled && (
<TabsContent
value="objectProperties"
className="jgis-panel-tab-content"
>
<ObjectPropertiesReact
setSelectedObject={setSelectedObjectProperties}
selectedObject={selectedObjectProperties}
formSchemaRegistry={props.formSchemaRegistry}
model={props.model}
/>
</TabsContent>
)}

{!settings.annotationsDisabled && (
<TabsContent value="annotations" className="jgis-panel-tab-content">
<AnnotationsPanel
annotationModel={props.annotationModel}
jgisModel={props.model}
></AnnotationsPanel>
</TabsContent>
)}
{!settings.annotationsDisabled && (
<TabsContent value="annotations" className="jgis-panel-tab-content">
<AnnotationsPanel
annotationModel={props.annotationModel}
jgisModel={props.model}
></AnnotationsPanel>
</TabsContent>
)}

{!settings.identifyDisabled && (
<TabsContent value="identifyPanel" className="jgis-panel-tab-content">
<IdentifyPanelComponent
model={props.model}
></IdentifyPanelComponent>
</TabsContent>
)}
</PanelTabs>
</div>
{!settings.identifyDisabled && (
<TabsContent
value="identifyPanel"
className="jgis-panel-tab-content"
>
<IdentifyPanelComponent
model={props.model}
></IdentifyPanelComponent>
</TabsContent>
)}
</PanelTabs>
</div>
</Draggable>
);
};
8 changes: 8 additions & 0 deletions packages/base/style/shared/tabs.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,15 @@
0 4px 8px 0 rgba(0, 0, 0, 0.2),
0 6px 20px 0 rgba(0, 0, 0, 0.19);
border-radius: 5px;
cursor: grab;
user-select: none;
-webkit-user-drag: none;
}

.jgis-panel-tabs:active {
cursor: grabbing;
}

.jgis-tabs-list {
display: inline-flex;
height: 2.5rem;
Expand Down
3 changes: 2 additions & 1 deletion yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1054,6 +1054,7 @@ __metadata:
lerna: ^8.1.9
npm-run-all: ^4.1.5
prettier: ^3.0.0
react-draggable: ^4.5.0
rimraf: ^3.0.2
typescript: ^5
webpack: ^5.76.3
Expand Down Expand Up @@ -10674,7 +10675,7 @@ __metadata:
languageName: node
linkType: hard

"react-draggable@npm:^4.4.5":
"react-draggable@npm:^4.4.5, react-draggable@npm:^4.5.0":
version: 4.5.0
resolution: "react-draggable@npm:4.5.0"
dependencies:
Expand Down
Loading