Display layer name field at top of "add layer" dialogs #966
+23
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added instructions for installing essential tools like Git, Python, and Micromamba.
Add installation instructions for essential tools
for more information, see https://pre-commit.ci
Co-authored-by: Matt Fisher <[email protected]>
|
|
mfisher87
reviewed
Oct 23, 2025
| sourceSchema['required'] = ['name', ...sourceSchema['required']]; | ||
| sourceSchema['properties'] = { | ||
| name: { type: 'string', description: 'The name of the source' }, | ||
| name: { type: 'string', description: 'The name of the source' , 'ui:autofocus':true}, |
There was a problem hiding this comment.
This works? That's cool if so! I expected this would have to be handled in the uiSchema instead of the json schema.
|
Nice work, thanks for the PR! TODO: Add the text "Resolves #767" to the PR description TODO: Rebase or otherwise fix history to include only the relevant commits TODO: Lint ( |
|
Integration tests report: appsharing.space |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Resolves #XXX.Failing lint checks can be resolved with:
pre-commit run --all-filesjlpm run lint📚 Documentation preview: https://jupytergis--966.org.readthedocs.build/en/966/
💡 JupyterLite preview: https://jupytergis--966.org.readthedocs.build/en/966/lite