Skip to content

Improve typing for react states #967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 3, 2025
Merged

Improve typing for react states #967

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bca1bc
Improve typing for react states
gaolinai8888 Oct 24, 2025
59017e9
Edit according to comments
gaolinai8888 Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions packages/base/src/dialogs/ProcessingFormDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,11 @@ const ProcessingFormWrapper: React.FC<IProcessingFormWrapperProps> = props => {
props.formErrorSignalPromise?.promise,
]).then(([ok, formChanged]) => {
okSignal.current = ok;
formErrorSignal.current = formChanged;
formErrorSignal.current = formChanged || undefined;
setReady(true);
});

let FormComponent;
let FormComponent: React.ComponentType<any>;
Copy link
Member

@mfisher87 mfisher87 Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

switch (props.processingType) {
case 'Dissolve':
FormComponent = DissolveForm;
Expand All @@ -65,7 +65,6 @@ const ProcessingFormWrapper: React.FC<IProcessingFormWrapperProps> = props => {
filePath={props.model.filePath}
model={props.model}
ok={okSignal.current}
cancel={props.cancel}
sourceData={props.sourceData}
schema={props.schema}
syncData={props.syncData}
Expand Down Expand Up @@ -183,5 +182,5 @@ export class ProcessingFormDialog extends Dialog<IDict> {
}
}

private okSignal: Signal<Dialog<any>, number>;
private okSignal: Signal<Dialog<IDict>, number>;
Copy link
Member

@mfisher87 mfisher87 Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

}
3 changes: 2 additions & 1 deletion packages/base/src/dialogs/symbology/symbologyDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@ const SymbologyDialog: React.FC<ISymbologyDialogProps> = ({
cancel,
}) => {
const [selectedLayer, setSelectedLayer] = useState<string | null>(null);
const [componentToRender, setComponentToRender] = useState<any>(null);
const [componentToRender, setComponentToRender] =
useState<JSX.Element | null>(null);
Copy link
Member

@mfisher87 mfisher87 Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯


let LayerSymbology: React.JSX.Element;

Expand Down
Loading