Migrate from ethers to alloy, a macro for calls, and bugfixes - #8
Open
BlinkyStitt wants to merge 35 commits into
Open
Migrate from ethers to alloy, a macro for calls, and bugfixes#8BlinkyStitt wants to merge 35 commits into
BlinkyStitt wants to merge 35 commits into
Conversation
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Expose CALL/DELEGATECALL/STATICCALL APIs and macro support; add tests for flag encoding. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Default to http://localhost:8545 when PROVIDER_URL is not set. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
…xactly what i want but macros and types like this are challenging
Owner
|
hey @BlinkyStitt sorry i didn't see this PR for so long :( i haven't had occasion to use this lib since the original code, but would be nice to have it usable still- happy to merge this if you are using it and it works? thanks for sharing :) |
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I migrated most of the code from ethers to alloy. Then I used some AI tools to finish the migration. I also worked with the AI to add some helpful macros for using a contract instance instead of taking the address. the old call way still works.
I also noticed that the example bin was not properly printing its logs and it was using delegatecall when it should have been using call. I fixed the decoding for dynamic types.
Before:
Now: