Add example script to check GCHP emission diagnostics entries in HISTORY.rc and HEMCO_Diagn.rc #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcpy/benchmark/modules/emission_species.yml - Added a comment that 'NO' must have quotes or else it will be interpreted as False gcpy/examples/check_gchp_emission_diags.py - Example script that reads GCHP emission diagnostic entries in HEMCO_Config.rc and HISTORY.rc template files to check for consistency. Will print lists of entries that are common to both files, and in one file but not in the other. CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <[email protected]>
gcpy/examples/diagnostics/check_emission_diags.py - Now return results in sorted order Signed-off-by: Bob Yantosca <[email protected]>
docs/source/Check-GCHP-Emission-Diags.rst - Documentation chapter for checking GCHP emission entries docs/source/index.rst - Added Check-GCHP-Emission-Diags to examples toctree CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <[email protected]>
yantosca
added
category: Feature Request
lizziel
requested changes
Apr 29, 2025
"commandsm" -> "commands" Signed-off-by: Bob Yantosca <[email protected]>
gcpy/examples/diagnostics/check_gchp_emission_diags.py - In the "if name == '__main__' section of the code, the command "raiseValueError(msg)" is now "raiseValueError(MSG)". Signed-off-by: Bob Yantosca <[email protected]>
lizziel
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Bob Yantosca
Institution: Harvard + GCST
Describe the update
We have added an example script (plus documentation) to check the emission entries in the GCHP template files
run/GCHP/HEMCO_Diagn.rc.templates/HEMCO_Diagn.rc.{simulation}andrun/GCHP/HISTORY.rc.templates/HISTORY.rc.{simulation}. This will make it less likely that diagnostic entries will be listed in one file but not in the other (as often happens when new diagnostics are added).Expected changes
will give output such as:
The output indicates that some diagnostics in
HEMCO_Diagn.rcare not present inHISTORY.rc, and should be added therefor consistency. A comment before the emission entry means that the diagnostic will be disabled by default.