-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Article : open buildings #1247
base: master
Are you sure you want to change the base?
Article : open buildings #1247
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Ça part en relecture @geotribu/relecture ! ℹ️ Aux relecteur/ices Merci d'utiliser autant que possible le mode Suggestion de la review : https://docs.github.com/fr/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/reviewing-proposed-changes-in-a-pull-request#starting-a-review C'est vraiment IMPORTANT pour le confort des auteurs/ices 🙏 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Article très chouette, juste une micro remarque générale : je m'attendais à un petit avis technique ou même personnelle, sur la complétude/précision de la donnée.
Hormis ça, quelques coquilles ou question de forme, rien de plus !
Co-authored-by: Aurélien Chaumet <[email protected]> Signed-off-by: Guilhem Allaman <[email protected]>
Co-authored-by: Aurélien Chaumet <[email protected]> Signed-off-by: Guilhem Allaman <[email protected]>
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
👏 Le markdown ajouté ou modifié est impeccable ! Merci 🥇 |
🎉 Le site de prévisualisation pour cette PR a été généré et est disponible sous ce lien. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merci pour la review @aurelienchaumet, tentative de prise en compte. Pour info, pas hyper calé(s) dans ces histoires de télédétection.
- un score de confiance indiquant la probabilité qu’il s’agisse d’un bâtiment | ||
- un [code Plus](https://fr.wikipedia.org/wiki/Open_Location_Code) correspondant au centre du bâtiment | ||
|
||
Le type de bâtiment n'est pas renseigné, contrairement à [aux données OpenStreetMap par exemple](https://wiki.openstreetmap.org/wiki/Key:building), seulement la géométrie et donc un score de confiance dont le seuil minimal de filtrage est fixé à 65%, ce qui peut parfois s'avérer assez bas (dis "camion!" :truck:). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review demandée ici, pas hyper expert des bâtiments OSM
Article sur les Open Buildings co-écrit avec Michel-Francis Kisweso @Michel-Francis, qui avait créé une issue à ce sujet il y a quelques mois.
Je me suis permis de commit en mettant Michel-Francis en co-auteur, compte-tenu des difficultés rencontrées en local pour forker + installer les outils nécessaires + la mécanique de contribution via git.
Closes #1167