Skip to content

Handle more gracefully checks on select_sql argument of DbToCSVOperator#241

Merged
augusto-herrmann merged 3 commits intomainfrom
issue-240
Mar 13, 2026
Merged

Handle more gracefully checks on select_sql argument of DbToCSVOperator#241
augusto-herrmann merged 3 commits intomainfrom
issue-240

Conversation

@augusto-herrmann
Copy link
Copy Markdown
Member

Fix #240

This will:

  • handle gracefully more corner cases of values that users pass to select_sql in DbToCSVOperator. Will handle Optional[str | Path] types. If a str, try to determine if it is a file path or a query string.
  • tolerate invalid values in int_columns, interpret as pd.NA if it's not possible to convert to integer, instead of generating an exception.

@augusto-herrmann augusto-herrmann self-assigned this Mar 13, 2026
@augusto-herrmann augusto-herrmann added the bug Something isn't working label Mar 13, 2026
@augusto-herrmann augusto-herrmann merged commit 4b36178 into main Mar 13, 2026
1 check passed
@augusto-herrmann augusto-herrmann deleted the issue-240 branch March 13, 2026 20:12
Copy link
Copy Markdown
Member

@marcusva86 marcusva86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using a long string value in select_sql argument of DbToCSVOperator begets an exception

2 participants