Skip to content

feat: add light global theme, remove assets from repo#102

Merged
NiHaiden merged 5 commits into
mainfrom
light-theme
Jan 12, 2026
Merged

feat: add light global theme, remove assets from repo#102
NiHaiden merged 5 commits into
mainfrom
light-theme

Conversation

@renner0e

@renner0e renner0e commented Jan 11, 2026

Copy link
Copy Markdown
Member

This doesn't change any defaults, it will still be dark and more
intended for completion as there was just this light counterpart
missing.

image image

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new light global theme and refactors the repository to use a git submodule for branding assets. The changes are mostly correct, but I found a typo in the new light theme's configuration that will prevent the splash screen from loading correctly. My review includes a suggestion to fix this.

@renner0e
renner0e force-pushed the light-theme branch 3 times, most recently from 4259952 to 24eda8a Compare January 11, 2026 22:23
@renner0e

Copy link
Copy Markdown
Member Author

this is fine and doesn't blow anything up

@renner0e
renner0e marked this pull request as ready for review January 12, 2026 14:45
@renner0e
renner0e marked this pull request as draft January 12, 2026 14:55
This doesn't change any defaults, it will still be dark and more
intended for completion as there was just this light counterpart
missing.
adds the Plasma made by KDE in the bottom right corner
@renner0e
renner0e marked this pull request as ready for review January 12, 2026 15:49
@NiHaiden
NiHaiden added this pull request to the merge queue Jan 12, 2026
Merged via the queue into main with commit b11f0e8 Jan 12, 2026
2 checks passed
@NiHaiden
NiHaiden deleted the light-theme branch January 12, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants