Skip to content

fix: make all partial args result in optional arg #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Yash-Singh1
Copy link
Contributor

This PR makes it so that functions that have all of their args set to optional don't have to pass an empty object to the session query to fix type errors.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Collaborator

@ianmacartney ianmacartney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh, very slick! Have you installed it to try it out?

Copy link

pkg-pr-new bot commented Aug 18, 2025

Open in StackBlitz

npm i https://pkg.pr.new/get-convex/convex-helpers@731

commit: 4e186e0

@ianmacartney
Copy link
Collaborator

The version above should be good to validate ^.
I'll merge it and release once I have a chance to try it. but you can use the version above in the meantime

@Yash-Singh1
Copy link
Contributor Author

Just tested it with the snapshot you provided. I can confirm that it's working
Screenshot 2025-08-18 at 5 01 40 PM

@ianmacartney ianmacartney merged commit de92e9f into get-convex:main Aug 20, 2025
3 checks passed
@ianmacartney
Copy link
Collaborator

nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants