fix(menubar): reduce repeated status parsing (#486) + clock-skew guard - #499
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Keeps the perf win from PR #486 (yesterday stays cached, no re-parse every run) but restores a narrow safety guard: drop any cached entry dated today or later before computing the gap range. The cache only ever stores complete past days, so a >= today entry can only come from the clock moving backward or a stale older cache; without this it would be served frozen instead of being recomputed live. Yesterday and earlier are untouched, so this does not re-parse already-cached days. Adds a regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #486. Contains @vaibhavarora14's repeated-status-parsing fix (their commits preserved) plus one maintainer follow-up commit.
What #486 does (closes #484)
Follow-up commit on this branch
The original change removed a block that also self-healed a rare case: a cached entry dated today or later (from the system clock moving backward, or a stale older cache) would be served frozen instead of recomputed live. Re-added as a narrow guard that purges only
>= todayentries, so yesterday and earlier stay cached (the perf win is preserved) while today is always recomputed live. Added a regression test.Verification
npm run buildpasses.usage-aggregatortimeout flake (passes in isolation at ~3.5s), unrelated to this change.