feat(tui): mouse-wheel scrolling for the dashboard viewport - #951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dashboard's ScrollableViewport only answered keyboard keys; on the alternate screen the terminal never sends wheel events unless mouse reporting is on, so mouse scrolling did nothing.
The viewport now enables SGR mouse reporting (DECSET 1000+1006) while mounted and scrolls three lines per wheel tick. wheelDelta() parses only wheel buttons 64/65; clicks, drags, and modified wheel events contribute nothing. Tracking is disabled on unmount, so quitting or switching views restores the terminal.
Known tradeoff, documented at the code site: while tracking is on, click-drag text selection needs Shift held in most terminals.
Verified live in a pty drive against real data: tracking enabled on mount, wheel-down re-renders the scrolled frame, a click press/release at a digit-bearing coordinate does NOT leak into Ink's key parser (period tabs unchanged), and quit emits the tracking-off sequence. Unit tests cover the wheel parser (ticks, mixed directions, clicks/drags/modified wheels ignored, partial sequences); tsc clean; dashboard suite green.