Better support for DocBlock parameters #2432
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distantnative
force-pushed
the
v5/parameters
branch
from
080c7a0 to
c1e06b8
Compare
|
Is there a good place where I can check the before and after state? |
|
https://getkirby.test/docs/reference/objects/toolkit/collection/sort But @lukasbestle wanted to review this, so you might not have to do it. |
|
There seems to be an issue with optional parameters that have null as default value. Check out the second argument here http://getkirby.test/docs/reference/objects/toolkit/collection/slice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of changes
$argsparameter is removed if any other parameter is documented