Skip to content

Conversation

@Jovis7
Copy link
Contributor

@Jovis7 Jovis7 commented Jan 12, 2025

@Jovis7 Jovis7 requested a review from hwh33 January 12, 2025 14:30
Copy link

@hwh33 hwh33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mostly looks good @Jovis7, just a couple of small comments.

Copy link

@hwh33 hwh33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working for me @Jovis7, awesome work!

To test, I ran a client configured with "tlsFrag": "index:2" against (1) a TLS proxy based off main and (2) a TLS proxy based off this branch. The client failed to connect in the first case, but worked in the second case when dialing a proxy running your changes.

Let's merge this on Monday!

@Jovis7 Jovis7 merged commit 2dbc90c into main Feb 10, 2025
1 check passed
@hwh33
Copy link

hwh33 commented Feb 10, 2025

This was merged (and thus deployed) 18 hours ago, with no ill effect to HTTPS traffic:

image

We should be good to deploy record fragmentation tracks now too. Excellent work @Jovis7!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants