upgrade broflake, fix reporting bug #657
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
noahlevenson
left a comment
noahlevenson
left a comment
There was a problem hiding this comment.
Since I'm just coming back after 17 months away from the codebase, I probably don't have enough context to provide a well reasoned review here. But don't let me block the merge!
Contributor
Author
|
Closing this since there are new updates in github.com/getlantern/unbounded, that should be used over this when the broflake package is updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades the broflake/unbounded package, and also adds some otel values to fix a reporting bug that started with changing the package version