add support for otel in env variable #663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds support for configuring the OpenTelemetry (OTEL) endpoint via the OTEL_EXPORTER_OTLP_ENDPOINT environment variable, with automatic detection of secure vs. insecure connections based on port 443. The implementation allows developers to override the default telemetry endpoint for testing or alternative deployments.
Key changes:
- Added environment variable support for OTEL endpoint configuration in
http_proxy.go - Implemented automatic insecure connection detection in
otel.gobased on port 443 presence - Refactored OTEL client initialization to use option slices for both tracer and metrics providers
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| http_proxy.go | Added getTelemetryEndpoint() function to read OTEL endpoint from environment variable with fallback to default |
| otel/otel.go | Added port-based insecure connection logic for both tracer and metrics providers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.