declare ARG BUILD_ARG #68
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a new build argument (BUILD_ARG) to the Dockerfile to allow passing custom arguments to the Go build command. The argument is declared at line 4 and utilized at line 30 where it's conditionally expanded into the go build command.
Key Changes:
- Added
ARG BUILD_ARGdeclaration to enable custom build flags for the Go build process
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| FROM --platform=$BUILDPLATFORM golang:1.24-bullseye as builder | ||
| ARG TARGETOS TARGETARCH | ||
| ARG GOPROXY="" | ||
| ARG BUILD_ARG |
There was a problem hiding this comment.
The ARG name "BUILD_ARG" is too generic and doesn't convey its purpose. Since this is used to pass additional arguments to the go build command (line 30), consider renaming it to something more descriptive like "GO_BUILD_ARGS" or "BUILD_FLAGS" to make its intent clearer for users.
| @@ -1,6 +1,7 @@ | |||
| FROM --platform=$BUILDPLATFORM golang:1.24-bullseye as builder | |||
| ARG TARGETOS TARGETARCH | |||
| ARG GOPROXY="" | |||
There was a problem hiding this comment.
Consider adding a comment documenting the purpose of BUILD_ARG and what kind of values it expects. This will help users understand how to pass custom build arguments when building the Docker image.
| ARG GOPROXY="" | |
| ARG GOPROXY="" | |
| # BUILD_ARG allows passing custom arguments to the 'go build' command, such as build tags or ldflags. | |
| # Example: docker build --build-arg BUILD_ARG='-ldflags "-s -w"' |
No description provided.