fix build #70
fix build #70
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the BUILD_DATE build argument from the Docker build process to fix a build issue. The change eliminates the build date from being passed to the application during compilation.
- Removes BUILD_DATE ARG from Dockerfile
- Removes BUILD_DATE from ldflags in the go build command
- Removes BUILD_DATE from build-args in GitHub Actions workflows
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Dockerfile | Removes BUILD_DATE argument declaration and its usage in the ldflags during the go build command |
| .github/workflows/push_branch.yaml | Removes BUILD_DATE from the Docker build arguments in the branch push workflow |
| .github/workflows/push.yaml | Removes BUILD_DATE from the Docker build arguments in the main push workflow |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| echo "Building for $GOOS/$GOARCH using CC=$CC CXX=$CXX" && \ | ||
| go build -v -tags "with_gvisor,with_quic,with_dhcp,with_wireguard,with_utls,with_acme,with_clash_api" \ | ||
| -ldflags="-X main.version=${VERSION} -X main.commit=${COMMIT} -X main.buildDate=${BUILD_DATE}" \ | ||
| -ldflags="-X main.version=${VERSION} -X main.commit=${COMMIT}" \ |
There was a problem hiding this comment.
While BUILD_DATE has been removed from the ldflags, the Go code still references the buildDate variable. The variable is declared in cmd/main.go (line 29) and used in a log statement in cmd/cmd_run.go (line 116). This will cause the buildDate to always be empty at runtime, which may result in incomplete build information being logged. Consider either removing the buildDate variable and its usage from the Go code, or keeping the BUILD_DATE build argument if this information is needed.
No description provided.