fix logging #71
Merged
fix logging #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors logging calls in the OpenTelemetry integration to use a more consistent approach: changing from printf-style formatting to variadic argument passing, and updating error logging to use exception wrapping with E.Cause.
- Changed error logging from printf-style format strings to error wrapping with
E.Cause - Refactored debug logging statements from printf-style formatting (
%v) to variadic argument passing
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
| if opts.FrontendProvider != "" { | ||
| log.Debug("Will report frontend provider %v in dc %v", opts.FrontendProvider, opts.FrontendDC) | ||
| log.Debug("Will report frontend provider in dc ", opts.FrontendProvider, opts.FrontendDC) |
There was a problem hiding this comment.
The log message has incorrect formatting with double spaces between "provider" and "in". The message should read "Will report frontend provider in dc" with the variables appended. This will result in an unclear log message like "Will report frontend provider in dc value1 value2" instead of a properly formatted message.
Suggested change
| log.Debug("Will report frontend provider in dc ", opts.FrontendProvider, opts.FrontendDC) | |
| log.Debug("Will report frontend provider in dc ", opts.FrontendProvider, opts.FrontendDC) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.