fix logging #72
fix logging #72
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes logging calls to use the correct API for the logger implementation. The logging library uses variadic arguments that are automatically formatted, not printf-style format strings.
- Removed incorrect printf-style format specifiers (
%s,%v) from log messages - Updated log calls to pass arguments separately for automatic formatting
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| otel/otel.go | Removed %v format specifier from debug log message for OTEL endpoint |
| cmd/cmd_run.go | Removed %s format specifiers from info log message displaying build version and commit |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| func run(configPath string) error { | ||
| log.Info("build info: version=%s, commit=%s", version, commit) | ||
| log.Info("build info: version , commit ", version, commit) |
There was a problem hiding this comment.
The log message has awkward spacing and unclear formatting. The message "build info: version , commit " has spaces before commas and a trailing space, making it difficult to read. Consider using a clearer format such as "build info: version=", "commit=" or "build info: version:", "commit:" to properly separate the labels from the values.
| log.Info("build info: version , commit ", version, commit) | |
| log.Info(fmt.Sprintf("build info: version=%s, commit=%s", version, commit)) |
No description provided.