add missing file #78
Merged
add missing file #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Merging. Forgot to commit this definition file. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a missing adapter interface definition file that was forgotten in a previous change. The new file defines the ClientContextManager interface which wraps adapter.ConnectionTracker from sing-box and adds an AppendTracker method.
Key Changes:
- Added
adapter/clientcontext_manager.godefining theClientContextManagerinterface
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| package adapter | ||
|
|
||
| import "github.com/sagernet/sing-box/adapter" | ||
|
|
There was a problem hiding this comment.
The exported interface ClientContextManager should have a documentation comment describing its purpose and usage. According to Go conventions, all exported types should have a doc comment that starts with the type name.
Suggested change
| // ClientContextManager manages connection tracking for a client context by | |
| // embedding a ConnectionTracker and allowing additional trackers to be appended. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot to include the adapter definition file.