receiving WATER dir as an option and creating required directories #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies WATER outbound configuration by consolidating two separate directory options into a single root directory. The code now automatically creates wasm_files and wazero_compilation_cache subdirectories under the specified WATER directory, improving the user experience by requiring only one directory configuration instead of two.
- Replaced
WASMStorageDirandWazeroCompilationCacheDirwith a singleDiroption - Automatically creates required subdirectories (
wasm_filesandwazero_compilation_cache) within the specified WATER directory - Updated validation to check for the new unified directory option
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| protocol/water/outbound.go | Constructs subdirectory paths from the new Dir option and creates them automatically |
| option/water.go | Consolidates two directory fields into a single Dir field with updated documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.