Skip to content

fix(removeQueue): add panic recovery and double-check for outbound removal #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
garmr-ulfr merged 2 commits into from
Jan 2, 2026
+11 −0
Merged

fix(removeQueue): add panic recovery and double-check for outbound removal #80

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a80c7f2
fix(removeQueue): add panic recovery and double-check for outbound re…
garmr-ulfr Dec 31, 2025
72abe52
remove tag from pending if already removed
garmr-ulfr Dec 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions adapter/groups/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,13 +306,24 @@ func (rq *removalQueue) checkPending() {
}

if len(toRemove) > 0 {
defer func() {
if err := recover(); err != nil {
rq.logger.Error("panic during outbound/endpoint removal", "error", err)
}
}()
rq.mu.Lock()
defer rq.mu.Unlock()
for _, tag := range toRemove {
item, exists := rq.pending[tag]
if !exists {
continue
}
// double check if outbound/endpoint still exists
if _, exists = rq.outMgr.Outbound(tag); !exists {
rq.logger.Trace("outbound already removed", "tag", tag)
delete(rq.pending, tag)
continue
}
rq.logger.Debug("removing outbound", "tag", tag)
if item.isEndpoint {
rq.epMgr.Remove(tag)
Expand Down
Loading