-
Notifications
You must be signed in to change notification settings - Fork 5
Proxyless toggle setting on Android #1367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
TODO:
|
|
I added a couple of translation strings to assets/locales/en-us.po. What's the process for getting those translated @Derekf5? |
|
This just needs some translations |
|
Oh and we need to merge the related flashlight branch... |
|
Hey @greySkiesMarsh |
This pull request introduces support for a new "proxyless" feature across multiple components of the application. Key changes include backend logic to manage proxyless settings, UI updates to expose the feature in the settings, and necessary updates to the session model. Additionally, minor improvements and fixes were made to existing code.
Proxyless Feature Implementation:
Backend support for proxyless settings:
pathProxylessininternalsdk/session_model.goto define the proxyless path.setProxylessandProxylessEnabledmethods inSessionModelto handle proxyless state management. [1] [2] [3]UI integration for proxyless toggle:
lib/features/account/settings.dart, including aCupertinoSwitchfor toggling the proxyless state.lib/common/ui/image_paths.dart.Session model updates:
proxylessNotifierand corresponding methods tolib/features/home/session_model.dartfor managing proxyless state in the app. [1] [2] [3]Minor Improvements and Fixes:
Improved directory creation in
hit_proxy.bash:mkdir -pwithmkdir -pvfor verbose output and added error handling when fetching proxy configuration.UI consistency updates:
lib/features/account/settings.dartfor better formatting. [1] [2]CupertinoSwitchproperty name inlib/features/account/split_tunneling.dart.