Skip to content

Added numerous operations like concat(...), coalesce(...), abs(...), etc#20

Merged
liuzicheng1987 merged 26 commits intomainfrom
f/operations
Jun 22, 2025
Merged

Added numerous operations like concat(...), coalesce(...), abs(...), etc#20
liuzicheng1987 merged 26 commits intomainfrom
f/operations

Conversation

@liuzicheng1987
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @liuzicheng1987, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the sqlgen library by integrating a wide range of SQL operations directly into its type-safe C++ query building interface. The core change involves a fundamental refactoring of how SQL expressions are represented internally, moving to a more generalized 'Operation' concept. This allows for much more complex and expressive queries to be constructed in C++, with compile-time guarantees for type correctness and nullability, and is supported by new documentation and comprehensive tests for both PostgreSQL and SQLite.

Highlights

  • Expanded SQL Functionality: I've introduced a comprehensive set of SQL operations directly into the C++ API, including mathematical functions (abs, ceil, floor, exp, ln, log2, sqrt, sin, cos, tan, round), string manipulation (length, lower, upper, ltrim, rtrim, trim, replace, concat), type conversion (cast), and null handling (coalesce). This significantly broadens the types of queries that can be constructed with sqlgen.
  • Unified Expression Representation: A major refactoring was performed to introduce a new Operation type in the transpilation and dynamic layers. This unified representation allows for arbitrary nesting and chaining of expressions, making arithmetic, string, and other operations first-class citizens in the query builder. This also enables operations to be used seamlessly within WHERE clauses and SELECT statements.
  • Enhanced Type Safety and Nullability: Robust compile-time type checking and nullability propagation rules have been implemented for all new operations. This ensures that the C++ types inferred for query results accurately reflect the potential nullability of the corresponding SQL expressions, preventing common runtime errors and improving code reliability.
  • Comprehensive Documentation and Testing: A new, detailed documentation page (docs/other_operations.md) has been added to explain the usage and semantics of these new operations, including their nullability behavior. Extensive new test cases have also been added for both PostgreSQL and SQLite to validate the functionality across various scenarios, including operations on nullable columns.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several new SQL operations and functions, including concat, coalesce, abs, and others, enhancing the sqlgen library's capabilities. It also includes updates to documentation and internal structures to support these new features. The code introduces new operations and functions, and also updates the documentation.

Comment thread README.md
@liuzicheng1987 liuzicheng1987 merged commit 30ba548 into main Jun 22, 2025
16 checks passed
@liuzicheng1987 liuzicheng1987 deleted the f/operations branch June 22, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant