Skip to content

Added operations on time stamps#24

Merged
liuzicheng1987 merged 12 commits intomainfrom
f/time_stamp_handling
Jul 2, 2025
Merged

Added operations on time stamps#24
liuzicheng1987 merged 12 commits intomainfrom
f/time_stamp_handling

Conversation

@liuzicheng1987
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @liuzicheng1987, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the sqlgen library by introducing robust support for timestamp and duration operations. It allows users to perform date/time arithmetic and extract specific components from timestamp columns in a type-safe C++ manner, which is then correctly transpiled into appropriate SQL for both PostgreSQL and SQLite databases. This expands the library's capabilities for handling time-series data and complex date-based queries.

Highlights

  • Timestamp and Duration Operations: Introduced comprehensive support for arithmetic operations (+, -) on timestamp columns using std::chrono::duration types, and added functions for extracting date/time components (year, month, day, hour, minute, second, weekday) and calculating differences (days_between, unixepoch).
  • Type System Enhancements: Added Date and DateTime type aliases, along with new type traits (is_duration, is_timestamp) and updated type deduction logic to correctly handle timestamp and duration types throughout the sqlgen framework.
  • Database Compatibility: Implemented specific SQL generation logic for the new timestamp and duration operations, ensuring compatibility and correct translation for both PostgreSQL and SQLite databases.
  • New Test Coverage: Added new test cases for both PostgreSQL and SQLite to validate the functionality of timestamp arithmetic and date/time component extraction in SELECT and WHERE clauses.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces significant functionality for handling timestamp and duration operations. I've identified a few critical issues related to correctness that need to be addressed, particularly in the transpilation::Operation logic and the PostgreSQL SQL generation for unixepoch. I've also included some suggestions to improve maintainability and fix issues in the new tests.

Comment thread include/sqlgen/transpilation/Operation.hpp
Comment thread src/sqlgen/postgres/to_sql.cpp Outdated
Comment thread include/sqlgen/transpilation/make_field.hpp Outdated
Comment thread tests/postgres/test_select_from_with_timestamps.cpp Outdated
@liuzicheng1987 liuzicheng1987 merged commit f95156d into main Jul 2, 2025
16 checks passed
@liuzicheng1987 liuzicheng1987 deleted the f/time_stamp_handling branch August 21, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant