[draft] import_page: support file scheme and use bs4 to workaround missing 'body' element #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfontein
changed the title
Kwpolska
reviewed
Feb 17, 2025
jirib
commented
Feb 17, 2025
v8/import_page/import_page.py
Outdated
| document = doc_template.format( | ||
| title=title, | ||
| slug=slug, | ||
| content=node.prettify() |
There was a problem hiding this comment.
Should we leave the HTML as it is? If it is 'article' should I just get 'article' content (mostly likely the website template would already have 'article' element) ???
There was a problem hiding this comment.
I tried to add a functionality for this topic, see ab15bed .
There was a problem hiding this comment.
I think we should remove the wrapper element (e.g. <article>) by default.
jirib
force-pushed
the
support_file_scheme
branch
from
8c15716 to
ab15bed
Compare
jirib
changed the title
Kwpolska
reviewed
Feb 23, 2025
Comment on lines
+70
to
+77
| while args: | ||
| arg = args.pop(0) | ||
| if arg == "-s" and args: | ||
| selector = args.pop(0) | ||
| elif arg == "-e" and args: | ||
| extractor = args.pop(0) | ||
| else: | ||
| urls.append(arg) # Assume it's a page URL |
There was a problem hiding this comment.
You don’t need to parse args yourself, you should use the built-in support in doit. See just about any command plugin for an example.
Comment on lines
+43
to
+46
| args = sys.argv[1:] | ||
| selector = None # 'body' | ||
| extractor = None # 'lambda node: BeautifulSoup(node.decode_contents(), "html.parser").prettify()' | ||
| urls = [] |
|
|
||
| doc_template = '''<!-- | ||
| .. title: {title} | ||
| .. slug: {slug} |
There was a problem hiding this comment.
Consider also adding date (defaulting to now is fine).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support file scheme and use bs4 to workaround missing 'body' element