Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin inventory and migration status #1291

Merged
merged 4 commits into from
Aug 30, 2020
Merged

Plugin inventory and migration status #1291

merged 4 commits into from
Aug 30, 2020

Conversation

kdeldycke
Copy link
Contributor

@kdeldycke kdeldycke commented Aug 28, 2020

Changes:

  • Add migration status of all plugins to keep track of progress.
  • Add missing entries.
  • Removes duplicate entries.
  • Links to hosted plugin sub-folder.
  • Links to external plugins (registered here by the way of git submodules).
  • Links to migrated plugin repository.
  • Re-order entries by their order of appearance in the repository.

I propose to add the following states symbols:

That way, once all plugins are marked as greem (either ❎ or ✅), we can safely archive that mono-repo for good.

@kdeldycke kdeldycke changed the title Add migration status. [WIP] Add migration status. Aug 28, 2020
@avaris
Copy link
Member

avaris commented Aug 28, 2020

For some reason, I don't like the wall of ❌s. How about leaving them empty? Also maybe a link to migrated repo on ✅s?

@kdeldycke
Copy link
Contributor Author

@avaris Ah yes, you're probably right. ❌ might be a little bit too aggressive. I'll leave them empty then. Good call on linking ✅ BTW. I'll update my PR.

@kdeldycke kdeldycke marked this pull request as draft August 28, 2020 15:45
@kdeldycke kdeldycke changed the title [WIP] Add migration status. Add plugin migration status Aug 28, 2020
@kdeldycke kdeldycke changed the title Add plugin migration status Plugin inventory and migration status Aug 28, 2020
@kdeldycke kdeldycke marked this pull request as ready for review August 28, 2020 18:42
@kdeldycke
Copy link
Contributor Author

I've finished to inventory all plugins in the mono-repo and their status.

This PR is ready to be merged.

@justinmayer
Copy link
Member

justinmayer commented Aug 29, 2020

What if we changed the Migration column header to an emoji? Maybe a question mark? (❓) That would make that column much narrower while still at least conveying the basic concept of "status", while of course the real explanation is just above. Any thoughts on that?

@kdeldycke
Copy link
Contributor Author

@justinmayer oh, you mean only changing the title of the column from Migration to ?

@avaris
Copy link
Member

avaris commented Aug 29, 2020

Those checkmarks look really subtle on my Windows system, for some reason:
Capture

Here are a few others that look OK here.
✔✖⚠❓❗

@justinmayer
Copy link
Member

@kdeldycke: Yes, sorry for not being clearer. I did indeed mean changing the column header from from Migration to .

@kdeldycke
Copy link
Contributor Author

@justinmayer found a better emoji: the information sign => ℹ️

@avaris I just replaced all occurrences of by .

It's my last round of tweak, after that I'll just follow your instructions if things are not good to you. I'm not that interested in choosing the color of the bikeshed! 😆 I just want to create an authoritative source of the plugin migration progress! 🙂

@avaris
Copy link
Member

avaris commented Aug 30, 2020

Thank you for doing the work and I know I'm being nitpicky. Don't worry, I can tweak it later.

@avaris
Copy link
Member

avaris commented Aug 30, 2020

I just added a commit with what I think looks readable on most platforms (the ones I can test at least).

@kdeldycke
Copy link
Contributor Author

@avaris aha no worries! And thanks for testing and fixing this on other platforms! 😃

LGTM, feel free to merge upstream! 👍

@justinmayer
Copy link
Member

@kdeldycke / @avaris: Many thanks for your work on this. Nice to have a way for us to track this!

@justinmayer justinmayer merged commit 5d216c2 into getpelican:master Aug 30, 2020
@kdeldycke kdeldycke deleted the migration-status branch August 30, 2020 13:11
@kdeldycke kdeldycke mentioned this pull request Aug 31, 2020
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants