feat(pelican-bootstrap3): added readtime support #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tried to add readtime support to pelican-bootstrap3 theme based on the way I am using it. I find the read time is a great feature to have in a blog site. Do you want to handle this differently than the way I have added it? Please let me know @justinmayer |
ivanhercaz
reviewed
Dec 11, 2019
There was a problem hiding this comment.
Hi @srininara! I am agree with you, readtime is very interesting and useful. However, I think before approve this change would be necessary to document a bit about it. Just some points I recommend you to clarify in the theme documentation (in this case, the README.md):
- How the user can activate this plugin (e.g., name of the plugin to introduce in
PLUGINS). - How the user can use this plugin?
- What plugin is using pelican-bootstrap3? It seems there are at least three plugins: this one by JenkinsDev, this by wayofnumbers and this by jmaister. There is just one available in getpelican/pelican-plugins is the second one, developed by wayofnumbers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.