Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option strip_prefix #237

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

tpope
Copy link

@tpope tpope commented Jan 23, 2025

This is #77 rebased with the requested documentation change.

@tpope tpope requested a review from andreiborza as a code owner January 23, 2025 00:56
@andreiborza
Copy link
Member

Hey @tpope, thanks for the contribution.

We are currently in the process of evaluating what kind of options we want to keep around for this action and which to drop, I will keep this PR around until we have a clearer picture. That being said, could you provide a motivation for this change to help us make the decision easier? Would love to hear a bit about your workflow and what you're currently doing without this option.

@tpope
Copy link
Author

tpope commented Jan 23, 2025

I have a Node.js project that follows the common idiom of generated compiled assets into dist/, resulting in "sources" paths like ../src/foo.ts, ../node_modules/foo/index.js, etc. --url-prefix=/something --strip-prefix=.. is the only way I've found to prevent Sentry from including ../ in the final resolved stack trace paths.

The project is using legacy source maps and cannot be easily retooled to use debug IDs, for reasons.

@andreiborza
Copy link
Member

Thank you for the swift answer. I'll bring this up with the team and will let you know. Thanks again for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants