Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dotnet publish re-entrant #571

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

bruno-garcia
Copy link
Member

Use --skip-duplicate to allow the job to be retried

From docs:

When pushing multiple packages to an HTTP(S) server, treats any 409 Conflict response as a warning so that other pushes can continue.

Use --skip-duplicate to allow the job to be retried
@asottile-sentry
Copy link
Member

fwiw the craft targets are intended to not be reentrant to prevent accidental re-release

@bruno-garcia
Copy link
Member Author

Got it. I'm this case we end up with half the packages release and half not. Which is a pain to fix by hand. With this change we'll be able to finish the step at least.

@BYK
Copy link
Member

BYK commented Dec 5, 2024

@bruno-garcia when you check off a target in publish, it is skipped. Is this multiple packages in a single target? If so, this may be grounds for granting an exception maybe?

@bruno-garcia
Copy link
Member Author

bruno-garcia commented Feb 2, 2025

@bruno-garcia when you check off a target in publish, it is skipped. Is this multiple packages in a single target? If so, this may be grounds for granting an exception maybe?

It's a single target. It's just 1 command dotnet publish and it does the job on all packages.
The command is made re-entrant with the flag I added in this PR.

We don't really gain anything by not having that flag in, right? But definitely would be helpful having the flag in.

fwiw the craft targets are intended to not be reentrant to prevent accidental re-release

In this particular case, it won't re-release anything since dotnet publish either fails if it's already there, or just ignores it (the behavior I need with this PR)

@bruno-garcia bruno-garcia enabled auto-merge (squash) February 2, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants