Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(maven): Do not try to publish .module file when does not exist #584

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Jan 27, 2025

We have some repositories that do not use Gradle for publishing and therefore do not have the .module file, so we''re just checking for its presence before mentioning it to the ./mvnw gpg... command

Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adinauer adinauer merged commit fe0fce4 into master Jan 28, 2025
11 checks passed
@adinauer adinauer deleted the rz/fix/maven-publication-with-no-module branch January 28, 2025 07:06
@adinauer
Copy link
Member

Thanks for fixing!
Here's the error log message that was in the log of the failing release job:

Error: ts/mvnw: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-gpg-plugin:3.2.7:sign-and-deploy-file (default-cli) on project sentry-maven-plugin: Specified side artifact tmp/craft-5FNVwi/sentry-maven-plugin-0.1.0/sentry-maven-plugin-0.1.0.module does not exist -> [Help 1]

Here's a release that failed: getsentry/publish#4959

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants