feat: /usr/bin/script wrapper to send full tty output to sentry #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devenv/main.py
Outdated
| if rc == 0: | ||
| return rc | ||
|
|
||
| # i'd love to be able to send a full event in the child then |
There was a problem hiding this comment.
I wonder if we can do something something trace id and have both exist? and just link them after the fact?
There was a problem hiding this comment.
ahhh that might work, i'm thinking we start a transaction in the parent and start a span for the child process then only transaction.finish() if an error happens in the child
not sure what the transaction would look like in sentry ui (like, can we easily see the child error event) but gonna give it a go
joshuarli
added a commit
to getsentry/sentry
that referenced
this pull request
Jul 1, 2024
) This reverts commit 09cdabf. Wasn't roll forwardable anyways since `make instlal-py-dev` goes through do.sh, which I plan on removing. Functionality will be preserved as part of getsentry/devenv#124 where span durations would work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #91
devenv now executes itself with script to tee the full tty output into a log file, which is then uploaded to sentry as an attachent to an event in the case of an unsuccessful exit.
I wasn't able to find a way to upload an attachment to an event after-the-fact though, so we're missing out on any detailed stacktrace that occured in devenv.
Events are grouped under user@host so we can easily see someone's issue.
TODO: fetch the event title (based on returned event id) because these attachment names are not that helpful.
Probably as a followup though. https://docs.sentry.io/api/events/retrieve-an-event-for-a-project/