Adding eslint rule to prevent duplicate imports (#646)

getsentry · Sep 29, 2023 · 5e96ae4 · 5e96ae4
1 parent b06aa4b
commit 5e96ae4
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 7 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -25,6 +25,7 @@ module.exports = {
     '@typescript-eslint/no-unused-vars': ['error', { argsIgnorePattern: '^_' }],
     'prefer-const': 'error',
     'default-case': 'error',
+    'no-duplicate-imports': 'error',
     eqeqeq: ['error', 'smart'],
     'simple-import-sort/imports': [
       'error',

diff --git a/src/brain/notifyOnGoCDStageEvent/index.ts b/src/brain/notifyOnGoCDStageEvent/index.ts
@@ -7,8 +7,8 @@ import {
   GoCDBuildCause,
   GoCDPipeline,
   GoCDResponse,
+  GoCDStageData,
 } from '@types';
-import { GoCDStageData } from '@types';
 
 import { getChangedStack } from '@/api/github/getChangedStack';
 import { getRelevantCommit } from '@/api/github/getRelevantCommit';

diff --git a/src/brain/requiredChecks/recordFailures.ts b/src/brain/requiredChecks/recordFailures.ts
@@ -1,5 +1,4 @@
-import { CheckRun } from '@/types';
-import { Annotation } from '@/types';
+import { Annotation, CheckRun } from '@/types';
 import { db } from '@/utils/db';
 
 interface RecordFailuresParams {

diff --git a/src/utils/db/getFailureMessages.ts b/src/utils/db/getFailureMessages.ts
@@ -1,5 +1,4 @@
-import { GETSENTRY_ORG, GETSENTRY_REPO_SLUG } from '@/config';
-import { BuildStatus } from '@/config';
+import { BuildStatus, GETSENTRY_ORG, GETSENTRY_REPO_SLUG } from '@/config';
 import { SlackMessage } from '@/config/slackMessage';
 import { db } from '@utils/db';
 import { getTimestamp } from '@utils/db/getTimestamp';

diff --git a/src/utils/metrics.ts b/src/utils/metrics.ts
@@ -1,8 +1,7 @@
 import { BigQuery } from '@google-cloud/bigquery';
 import * as Sentry from '@sentry/node';
 
-import { DRY_RUN, PROJECT } from '@/config';
-import { PRODUCT_AREA_LABEL_PREFIX } from '@/config';
+import { DRY_RUN, PRODUCT_AREA_LABEL_PREFIX, PROJECT } from '@/config';
 
 import {
   calculateSLOViolationRoute,