fix(credentials)!: Bind delegated credential subjects#495
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
dcramer
force-pushed
the
codex/credential-subject-binding
branch
from
b210339 to
71fe667
Compare
dcramer
force-pushed
the
codex/credential-subject-binding
branch
from
71fe667 to
4329a73
Compare
dcramer
force-pushed
the
codex/credential-subject-binding
branch
from
4329a73 to
489a62a
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 489a62a. Configure here.
dcramer
force-pushed
the
codex/credential-subject-binding
branch
from
489a62a to
f89be19
Compare
Make trusted plugin credential subjects an unbound plugin API shape and bind them inside the dispatch runtime before persistence. Persisted dispatch records and sandbox egress contexts now require runtime-bound subjects, while scheduler task state keeps only the stable unbound subject. BREAKING CHANGE: AgentPluginCredentialSubject no longer accepts caller-provided bindings, plugin registrations no longer support credential-subject binding flags, and persisted system credential subjects must carry a runtime binding. Refs #449 Co-Authored-By: GPT-5 Codex <codex@openai.com>
dcramer
force-pushed
the
codex/credential-subject-binding
branch
from
f89be19 to
73e3f0d
Compare
dcramer
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #493. Trusted plugin dispatch now accepts only the stable unbound credential subject shape from plugin code; Junior binds that subject to the Slack DM destination inside the runtime before persisting a dispatch record.
Junior Impact
Scheduled Junior tasks keep durable state as
{type,userId,allowedWhen}and no longer store long-lived signatures. When heartbeat dispatches a due run, core signs the subject for the exact Slack DM destination and verifies it locally before storing the dispatch.Credential Boundary
Plugin registrations no longer have a credential-subject binding opt-in, and plugin input cannot provide a binding. Runtime-bound dispatch records and sandbox egress contexts are the only places bindings exist, so delegated user OAuth lookup remains separate from the system actor.
No Dispatch-Time Slack Lookup
Dispatch does not call Slack
conversations.infoto re-verify the user. It relies on the already verified Slack DM context that produced the unbound subject and the runtime-owned signature added at dispatch creation.Breaking Change
AgentPluginCredentialSubjectno longer accepts caller-providedbinding,JuniorPluginRegistrationInputno longer accepts credential-subject binding flags, and persisted system credential subjects without a runtime binding are invalid.Refs #449