chore(grouping): Add project_root
to debug_meta
schema
#4475
+8
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft until we decide if this is the right approach. (In other words, ignore the questions I asked below for now.)
As part of a larger bug fix, we are in the midst of trying to move
in_app
logic from the Python SDK to the sentry server. To do that, we need to send the app's root path in the event, which we are for now planning to include indebug_meta
.In my testing, I discovered that even though the
debug_meta
schema includes another
entry with the note/// Additional arbitrary fields for forwards compatibility
, in order for the project root data to make it all the way to the grouping algorithm it has to survive the normalizer, and to do that, it has to be an explicitly listed. (Reviewers, please correct me if I'm wrong about this.) This PR does that, and adds a note explaining the requirement for any future additions.Note to reviewers: I got the
metastructure
values from theabs_path
entry, to which theproject_root
will get compared. Happy to change any of them if needed. I also didn't add or modify any tests related to this change. If that's needed, I would appreciate some guidance as I've never worked in rust before.