Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(grouping): Add project_root to debug_meta schema #4475

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lobsterkatie
Copy link
Member

@lobsterkatie lobsterkatie commented Jan 28, 2025

Draft until we decide if this is the right approach. (In other words, ignore the questions I asked below for now.)


As part of a larger bug fix, we are in the midst of trying to move in_app logic from the Python SDK to the sentry server. To do that, we need to send the app's root path in the event, which we are for now planning to include in debug_meta.

In my testing, I discovered that even though the debug_meta schema includes an other entry with the note /// Additional arbitrary fields for forwards compatibility, in order for the project root data to make it all the way to the grouping algorithm it has to survive the normalizer, and to do that, it has to be an explicitly listed. (Reviewers, please correct me if I'm wrong about this.) This PR does that, and adds a note explaining the requirement for any future additions.

Note to reviewers: I got the metastructure values from the abs_path entry, to which the project_root will get compared. Happy to change any of them if needed. I also didn't add or modify any tests related to this change. If that's needed, I would appreciate some guidance as I've never worked in rust before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant