style: Swiftlint Override Super Required (#1313)

getsentry · Sep 3, 2021 · 90c7d80 · 90c7d80
1 parent 62a418f
commit 90c7d80
Show file tree

Hide file tree

Showing 26 changed files with 43 additions and 0 deletions.
diff --git a/.swiftlint.yml b/.swiftlint.yml
@@ -81,13 +81,18 @@ whitelist_rules:
   - void_return
   - weak_delegate
 identifier_name:
+  allowed_symbols: 
+    - i
+    - _
   min_length:
     - 2
     - 1
 force_try:
   severity: warning
 force_unwrapping:
   severity: error
+overridden_super_call:
+  severity: error
 line_length:
   - 220
 type_name:

diff --git a/Samples/iOS-ObjectiveC/iOS-ObjectiveCUITests/LaunchUITests.swift b/Samples/iOS-ObjectiveC/iOS-ObjectiveCUITests/LaunchUITests.swift
@@ -3,6 +3,7 @@ import XCTest
 class LaunchUITests: XCTestCase {
 
     override func setUpWithError() throws {
+        try super.setUpWithError()
         continueAfterFailure = false
     }
 

diff --git a/Samples/iOS-Swift/iOS-Swift/NibViewController.swift b/Samples/iOS-Swift/iOS-Swift/NibViewController.swift
@@ -6,6 +6,7 @@ class NibViewController: UIViewController {
     @IBOutlet var button: UIButton!
 
     override func viewDidLoad() {
+        super.viewDidLoad()
         button.backgroundColor = .systemPink
     }
 }
diff --git a/Samples/iOS-Swift/iOS-SwiftUITests/LaunchUITests.swift b/Samples/iOS-Swift/iOS-SwiftUITests/LaunchUITests.swift
@@ -3,6 +3,7 @@ import XCTest
 class LaunchUITests: XCTestCase {
 
     override func setUpWithError() throws {
+        try super.setUpWithError()
         continueAfterFailure = false
     }
 

diff --git a/Samples/iOS-SwiftUI/iOS-SwiftUI-UITests/LaunchUITests.swift b/Samples/iOS-SwiftUI/iOS-SwiftUI-UITests/LaunchUITests.swift
@@ -3,6 +3,7 @@ import XCTest
 class LaunchUITests: XCTestCase {
 
     override func setUpWithError() throws {
+        try super.setUpWithError()
         continueAfterFailure = false
     }
 

diff --git a/Samples/tvOS-Swift/tvOS-SwiftUITests/LaunchUITests.swift b/Samples/tvOS-Swift/tvOS-SwiftUITests/LaunchUITests.swift
@@ -3,6 +3,7 @@ import XCTest
 class LaunchUITests: XCTestCase {
 
     override func setUpWithError() throws {
+        try super.setUpWithError()
         continueAfterFailure = false
     }
 

diff --git a/Sentry.xcworkspace/xcshareddata/WorkspaceSettings.xcsettings b/Sentry.xcworkspace/xcshareddata/WorkspaceSettings.xcsettings
@@ -0,0 +1,8 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+<plist version="1.0">
+<dict>
+	<key>PreviewsEnabled</key>
+	<false/>
+</dict>
+</plist>
diff --git a/Tests/SentryTests/Helper/SentryLogTests.swift b/Tests/SentryTests/Helper/SentryLogTests.swift
@@ -3,6 +3,7 @@ import XCTest
 class SentryLogTests: XCTestCase {
 
     override func tearDown() {
+        super.tearDown()
         // Set back to default
         SentryLog.configure(true, diagnosticLevel: SentryLevel.error)
         SentryLog.setLogOutput(nil)

diff --git a/Tests/SentryTests/Helper/SentrySysctlTests.swift b/Tests/SentryTests/Helper/SentrySysctlTests.swift
@@ -5,6 +5,7 @@ class SentrySysctlTests: XCTestCase {
     private var sut: SentrySysctl!
 
     override func setUp() {
+        super.setUp()
         sut = SentrySysctl()
     }
 

diff --git a/Tests/SentryTests/Integrations/SentryAppStartTrackingIntegrationTests.swift b/Tests/SentryTests/Integrations/SentryAppStartTrackingIntegrationTests.swift
@@ -20,12 +20,14 @@ class SentryAppStartTrackingIntegrationTests: XCTestCase {
     private var sut: SentryAppStartTrackingIntegration!
 
     override func setUp() {
+        super.setUp()
         fixture = Fixture()
         SentrySDK.setAppStartMeasurement(nil)
         sut = SentryAppStartTrackingIntegration()
     }
 
     override func tearDown() {
+        super.tearDown()
         fixture.fileManager.deleteAppState()
         sut.stop()
     }

diff --git a/Tests/SentryTests/Integrations/SentryCrashScopeObserverTests.swift b/Tests/SentryTests/Integrations/SentryCrashScopeObserverTests.swift
@@ -18,11 +18,13 @@ class SentryCrashScopeObserverTests: XCTestCase {
     private let fixture = Fixture()
 
     override func setUp() {
+        super.setUp()
         sentrycrash_scopesync_reset()
         SentryCrash.sharedInstance().userInfo = nil
     }
 
     override func tearDown() {
+        super.tearDown()
         sentrycrash_scopesync_reset()
         SentryCrash.sharedInstance().userInfo = nil
     }

diff --git a/Tests/SentryTests/Integrations/SentryFramesTrackerTests.swift b/Tests/SentryTests/Integrations/SentryFramesTrackerTests.swift
@@ -21,6 +21,7 @@ class SentryFramesTrackerTests: XCTestCase {
     private var fixture: Fixture!
 
     override func setUp() {
+        super.setUp()
         fixture = Fixture()
     }
 

diff --git a/Tests/SentryTests/Integrations/SentryFramesTrackingIntegrationTests.swift b/Tests/SentryTests/Integrations/SentryFramesTrackingIntegrationTests.swift
@@ -20,6 +20,7 @@ class SentryFramesTrackingIntegrationTests: XCTestCase {
     private var sut: SentryFramesTrackingIntegration!
 
     override func setUp() {
+        super.setUp()
         sut = fixture.sut
     }
 

diff --git a/Tests/SentryTests/Integrations/SentryUIPerformanceTrackerTests.swift b/Tests/SentryTests/Integrations/SentryUIPerformanceTrackerTests.swift
@@ -37,6 +37,7 @@ class SentryUIPerformanceTrackerTests: XCTestCase {
     private var fixture: Fixture!
 
     override func setUp() {
+        super.setUp()
         fixture = Fixture()
     }
 

diff --git a/Tests/SentryTests/Networking/RateLimits/SentryConcurrentRateLimitsDictionaryTests.swift b/Tests/SentryTests/Networking/RateLimits/SentryConcurrentRateLimitsDictionaryTests.swift
@@ -6,6 +6,7 @@ class SentryConcurrentRateLimitsDictionaryTests: XCTestCase {
     private var sut: SentryConcurrentRateLimitsDictionary!
 
     override func setUp() {
+        super.setUp()
         currentDateProvider = TestCurrentDateProvider()
         sut = SentryConcurrentRateLimitsDictionary()
     }

diff --git a/Tests/SentryTests/Networking/RateLimits/SentryEnvelopeRateLimitTests.swift b/Tests/SentryTests/Networking/RateLimits/SentryEnvelopeRateLimitTests.swift
@@ -6,6 +6,7 @@ class SentryEnvelopeRateLimitTests: XCTestCase {
     private var sut: EnvelopeRateLimit!
 
     override func setUp() {
+        super.setUp()
         rateLimits = TestRateLimits()
         sut = EnvelopeRateLimit(rateLimits: rateLimits)
     }

diff --git a/Tests/SentryTests/Networking/SentryHttpDateParserTests.swift b/Tests/SentryTests/Networking/SentryHttpDateParserTests.swift
@@ -7,6 +7,7 @@ class SentryHttpDateParserTests: XCTestCase {
     private var sut: HttpDateParser!
 
     override func setUp() {
+        super.setUp()
         currentDateProvider = TestCurrentDateProvider()
         sut = HttpDateParser()
     }

diff --git a/Tests/SentryTests/Networking/SentryHttpTransportTests.swift b/Tests/SentryTests/Networking/SentryHttpTransportTests.swift
@@ -86,6 +86,7 @@ class SentryHttpTransportTests: XCTestCase {
     private var sut: SentryHttpTransport!
 
     override func setUp() {
+        super.setUp()
         fixture = Fixture()
         fixture.fileManager.deleteAllEnvelopes()
         fixture.requestManager.returnResponse(response: HTTPURLResponse())
@@ -94,6 +95,7 @@ class SentryHttpTransportTests: XCTestCase {
     }
 
     override func tearDown() {
+        super.tearDown()
         fixture.fileManager.deleteAllEnvelopes()
     }
 

diff --git a/Tests/SentryTests/Networking/SentryTransportInitializerTests.swift b/Tests/SentryTests/Networking/SentryTransportInitializerTests.swift
@@ -9,6 +9,7 @@ class SentryTransportInitializerTests: XCTestCase {
     private var fileManager: SentryFileManager!
 
     override func setUp() {
+        super.setUp()
         do {
             let options = Options()
             options.dsn = SentryTransportInitializerTests.dsnAsString

diff --git a/Tests/SentryTests/Protocol/SentryEnvelopeTests.swift b/Tests/SentryTests/Protocol/SentryEnvelopeTests.swift
@@ -72,10 +72,12 @@ class SentryEnvelopeTests: XCTestCase {
     private let fixture = Fixture()
 
     override func setUp() {
+        super.setUp()
         CurrentDate.setCurrentDateProvider(TestCurrentDateProvider())
     }
 
     override func tearDown() {
+        super.tearDown()
         do {
             let fileManager = FileManager.default
             if fileManager.fileExists(atPath: fixture.path) {

diff --git a/Tests/SentryTests/SentryCrash/SentryCrashInstallationReporterTests.swift b/Tests/SentryTests/SentryCrash/SentryCrashInstallationReporterTests.swift
@@ -10,13 +10,15 @@ class SentryCrashInstallationReporterTests: XCTestCase {
     private var sut: SentryCrashInstallationReporter!
 
     override func setUp() {
+        super.setUp()
         sut = SentryCrashInstallationReporter(inAppLogic: SentryInAppLogic(inAppIncludes: [], inAppExcludes: []))
         sut.install()
         // Works only if SentryCrash is installed
         sentrycrash_deleteAllReports()
     }
 
     override func tearDown() {
+        super.tearDown()
         sentrycrash_deleteAllReports()
         clearTestState()
     }

diff --git a/Tests/SentryTests/SentryCrash/SentryCrashStackEntryMapperTests.swift b/Tests/SentryTests/SentryCrash/SentryCrashStackEntryMapperTests.swift
@@ -9,6 +9,7 @@ class SentryCrashStackEntryMapperTests: XCTestCase {
     private var sut: SentryCrashStackEntryMapper!
 
     override func setUp() {
+        super.setUp()
         sut = SentryCrashStackEntryMapper(inAppLogic: SentryInAppLogic(inAppIncludes: [bundleExecutable], inAppExcludes: []))
     }
 

diff --git a/Tests/SentryTests/SentryHubTests.swift b/Tests/SentryTests/SentryHubTests.swift
@@ -58,6 +58,7 @@ class SentryHubTests: XCTestCase {
     private var sut: SentryHub!
 
     override func setUp() {
+        super.setUp()
         fixture = Fixture()
         fixture.fileManager.deleteCurrentSession()
         fixture.fileManager.deleteCrashedSession()
@@ -69,6 +70,7 @@ class SentryHubTests: XCTestCase {
     }
 
     override func tearDown() {
+        super.tearDown()
         fixture.fileManager.deleteCurrentSession()
         fixture.fileManager.deleteCrashedSession()
         fixture.fileManager.deleteAppState()

diff --git a/Tests/SentryTests/SentrySDKTests.swift b/Tests/SentryTests/SentrySDKTests.swift
@@ -57,6 +57,7 @@ class SentrySDKTests: XCTestCase {
     private var fixture: Fixture!
 
     override func setUp() {
+        super.setUp()
         fixture = Fixture()
     }
 

diff --git a/Tests/SentryTests/SentrySessionTests.swift b/Tests/SentryTests/SentrySessionTests.swift
@@ -5,6 +5,7 @@ class SentrySessionTestsSwift: XCTestCase {
     private var currentDateProvider: TestCurrentDateProvider!
 
     override func setUp() {
+        super.setUp()
         currentDateProvider = TestCurrentDateProvider()
         CurrentDate.setCurrentDateProvider(currentDateProvider)
     }

diff --git a/Tests/SentryTests/SentrySpanTests.swift b/Tests/SentryTests/SentrySpanTests.swift
@@ -30,6 +30,7 @@ class SentrySpanTests: XCTestCase {
 
     private var fixture: Fixture!
     override func setUp() {
+        super.setUp()
         fixture = Fixture()
         CurrentDate.setCurrentDateProvider(fixture.currentDateProvider)
     }