Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(feedback): accessibility audit action items #4698

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

armcknight
Copy link
Member

@armcknight armcknight commented Jan 10, 2025

for #4401; #skip-changelog

Copy link

github-actions bot commented Jan 10, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1225.10 ms 1235.39 ms 10.29 ms
Size 22.31 KiB 780.93 KiB 758.61 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
08e472f 1197.49 ms 1214.29 ms 16.80 ms
efb0147 1242.00 ms 1257.31 ms 15.31 ms
077e940 1227.31 ms 1246.51 ms 19.20 ms
0559a8f 1239.78 ms 1252.60 ms 12.83 ms
381380f 1201.56 ms 1220.08 ms 18.52 ms
1f9387b 1229.00 ms 1256.49 ms 27.49 ms
b9a9ffd 1201.61 ms 1215.06 ms 13.45 ms
76c2ac7 1226.84 ms 1247.22 ms 20.39 ms
061c982 1229.73 ms 1253.88 ms 24.14 ms
49819af 1263.92 ms 1275.66 ms 11.74 ms

App size

Revision Plain With Sentry Diff
08e472f 21.58 KiB 424.28 KiB 402.70 KiB
efb0147 22.84 KiB 403.52 KiB 380.67 KiB
077e940 21.58 KiB 706.97 KiB 685.39 KiB
0559a8f 21.58 KiB 419.81 KiB 398.23 KiB
381380f 20.76 KiB 436.29 KiB 415.53 KiB
1f9387b 21.58 KiB 654.26 KiB 632.68 KiB
b9a9ffd 21.58 KiB 418.43 KiB 396.85 KiB
76c2ac7 21.58 KiB 695.48 KiB 673.90 KiB
061c982 21.58 KiB 683.51 KiB 661.92 KiB
49819af 20.76 KiB 427.31 KiB 406.55 KiB

Previous results on branch: armcknight/feat(feedback)/accessibility-audit

Startup times

Revision Plain With Sentry Diff
3cbcd11 1220.02 ms 1242.74 ms 22.72 ms
0acedc3 1237.90 ms 1253.62 ms 15.72 ms
e3de806 1242.67 ms 1262.22 ms 19.56 ms

App size

Revision Plain With Sentry Diff
3cbcd11 22.31 KiB 774.49 KiB 752.17 KiB
0acedc3 22.31 KiB 780.06 KiB 757.75 KiB
e3de806 22.31 KiB 770.93 KiB 748.62 KiB

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 69.72477% with 165 lines in your changes missing coverage. Please review.

Project coverage is 91.940%. Comparing base (f3b8999) to head (d6aecd5).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
...serFeedback/SentryUserFeedbackFormController.swift 41.614% 94 Missing ⚠️
...UserFeedback/SentryUserFeedbackFormViewModel.swift 82.448% 43 Missing ⚠️
...rFeedback/SentryUserFeedbackWidgetButtonView.swift 0.000% 14 Missing ⚠️
...Feedback/SentryUserFeedbackIntegrationDriver.swift 0.000% 5 Missing ⚠️
...ations/UserFeedback/SentryUserFeedbackWidget.swift 0.000% 5 Missing ⚠️
...ts/Integrations/Feedback/SentryFeedbackTests.swift 96.428% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4698       +/-   ##
=============================================
+ Coverage   91.082%   91.940%   +0.857%     
=============================================
  Files          624       627        +3     
  Lines        72205     72967      +762     
  Branches     25652     26560      +908     
=============================================
+ Hits         65766     67086     +1320     
+ Misses        6345      5782      -563     
- Partials        94        99        +5     
Files with missing lines Coverage Δ
Sources/Swift/Helper/Bundle.swift 100.000% <100.000%> (ø)
...guration/SentryUserFeedbackFormConfiguration.swift 100.000% <ø> (+100.000%) ⬆️
...ts/Integrations/Feedback/SentryFeedbackTests.swift 97.101% <96.428%> (-2.899%) ⬇️
...Feedback/SentryUserFeedbackIntegrationDriver.swift 0.000% <0.000%> (ø)
...ations/UserFeedback/SentryUserFeedbackWidget.swift 0.000% <0.000%> (ø)
...rFeedback/SentryUserFeedbackWidgetButtonView.swift 0.000% <0.000%> (ø)
...UserFeedback/SentryUserFeedbackFormViewModel.swift 89.523% <82.448%> (ø)
...serFeedback/SentryUserFeedbackFormController.swift 41.614% <41.614%> (ø)

... and 59 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3b8999...d6aecd5. Read the comment docs.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants