-
-
Notifications
You must be signed in to change notification settings - Fork 372
chore: Merge changes of v8.57.3 back into main #6774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that the test server is running with a retry mechanism to avoid flakiness in CI.
Add decision log entry for v8 branch and explain how to release from it.
The SDK reported false frame delay statistics when it moved from the background to the foreground, which also led to falsely reported app hangs. Fixes GH-6345
* fix: Fix crash when last replay info is missing keys * Update changelog
…afe (#6573) * fix: Disable SessionSentryReplayIntegration if the environment is unsafe * Simplify shouldEnableSessionReplay * Rename test * Add log message * Update changelog * Safely unwrap SentryOptions
…in (#6678) * fix(session-replay): Update rendering method for fast view rendering (#6360) * fix(session-replay): Extend masking and focus masking on sensitive information (#6292) * test(session-replay): Add masking tests for common cases (#6567) * test(session-replay): Add masking tests for React Native views (#6568) * fix(session-replay): Fix conversion of frame rate to time interval (#6623) * test(session-replay): Add masking tests for edge cases (#6569) * test(session-replay): Add masking tests for UIKit views (#6570) * test(session-replay): Add masking tests for special views (#6571) * fix(session-replay): Include layer background color when checking if a view is opaque (#6629) * chore(tests): Remove snapshot testing to reduce repository size (#6631) * chore: Remove unwanted CHANGELOG entries from cherry-pick - Remove #5591 (minimum OS version warnings) - not related to session replay - Remove #6019 (SCNetworkReachability) - not related to session replay - Remove #6377 (thread event issue) - not related to session replay - Remove #6381 (frame delay) - duplicate/not related to session replay - Keep only session replay masking related changes * docs: Move changelog changes from v8.57.1 to unreleased * test: Resolve wrong assertions involed due to merge-conflict * chore: Update sdk_api_V9.json
…utUIKit (#6761) * fix: Remove full sentry being included when using SentryWithoutUIKit (#6754) * fix: Remove full sentry being included when using SentryWithoutUIKit * Update changelog * Add PR number to Changelog * Update changelog * Fix changelog * Remove unnecesary changelog changes * Update CHANGELOG.md Co-authored-by: Philip Niedertscheider <[email protected]> --------- Co-authored-by: Philip Niedertscheider <[email protected]>
…ly casting to UISplitViewController (#6771) * fix: Resolve SDK crash caused by UIPrintPanelViewController incorrectly casting to UISplitViewController * update changelog * Update changelog --------- Co-authored-by: Itay Brenner <[email protected]>
❌ 1 Tests Failed:
View the top 2 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
620c8fe to
94273c3
Compare
94273c3 to
47fa61a
Compare
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4bf98bf | 1219.13 ms | 1244.50 ms | 25.38 ms |
| 5cbd333 | 1220.78 ms | 1234.15 ms | 13.36 ms |
| c174e5e | 1209.65 ms | 1238.73 ms | 29.08 ms |
| 5aa3ce5 | 1222.78 ms | 1245.39 ms | 22.61 ms |
| be882e4 | 1199.35 ms | 1231.20 ms | 31.86 ms |
| 86eb6d5 | 1224.95 ms | 1251.82 ms | 26.87 ms |
| 9c75c11 | 1228.42 ms | 1262.81 ms | 34.39 ms |
| d0f70ce | 1226.54 ms | 1247.04 ms | 20.50 ms |
| 9ccc0f5 | 1227.59 ms | 1264.07 ms | 36.47 ms |
| e36128b | 1213.04 ms | 1248.60 ms | 35.56 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4bf98bf | 23.75 KiB | 919.70 KiB | 895.95 KiB |
| 5cbd333 | 23.74 KiB | 969.66 KiB | 945.92 KiB |
| c174e5e | 23.75 KiB | 953.92 KiB | 930.16 KiB |
| 5aa3ce5 | 23.75 KiB | 904.54 KiB | 880.79 KiB |
| be882e4 | 23.75 KiB | 946.69 KiB | 922.94 KiB |
| 86eb6d5 | 23.74 KiB | 1.02 MiB | 1016.53 KiB |
| 9c75c11 | 23.74 KiB | 1022.95 KiB | 999.20 KiB |
| d0f70ce | 23.75 KiB | 913.09 KiB | 889.34 KiB |
| 9ccc0f5 | 24.14 KiB | 1.01 MiB | 1014.11 KiB |
| e36128b | 23.75 KiB | 963.19 KiB | 939.44 KiB |
philipphofmann
approved these changes
Nov 14, 2025
Member
philipphofmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog
Closes #6775