Skip to content

Conversation

@itaybre
Copy link
Contributor

@itaybre itaybre commented Nov 14, 2025

Uploads an example binary for size analysis

Created a new SDK-Size target so we have a clean binary without other stuff included and better represent our SDK size.
This is why I am using Sentry as static too

Closes #6783

@itaybre itaybre added the ready-to-merge Use this label to trigger all PR workflows label Nov 14, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1218.71 ms 1259.34 ms 40.63 ms
Size 24.15 KiB 1.01 MiB 1012.19 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5c5648e 1234.44 ms 1253.79 ms 19.35 ms
daeeb27 1235.35 ms 1253.77 ms 18.42 ms
354b020 1223.88 ms 1236.82 ms 12.94 ms
7629df7 1224.80 ms 1250.29 ms 25.49 ms
b358363 1228.33 ms 1262.34 ms 34.01 ms
a4e1541 1229.56 ms 1264.33 ms 34.77 ms
0ee162c 1226.90 ms 1261.72 ms 34.83 ms
2675d3c 1218.94 ms 1239.36 ms 20.42 ms
a598105 1236.51 ms 1258.88 ms 22.37 ms
670b474 1225.33 ms 1259.59 ms 34.26 ms

App size

Revision Plain With Sentry Diff
5c5648e 23.75 KiB 879.60 KiB 855.86 KiB
daeeb27 23.75 KiB 989.12 KiB 965.37 KiB
354b020 23.75 KiB 878.19 KiB 854.44 KiB
7629df7 23.75 KiB 959.45 KiB 935.70 KiB
b358363 23.75 KiB 987.92 KiB 964.18 KiB
a4e1541 23.75 KiB 1023.82 KiB 1000.07 KiB
0ee162c 23.75 KiB 933.33 KiB 909.58 KiB
2675d3c 23.75 KiB 928.16 KiB 904.41 KiB
a598105 23.75 KiB 968.24 KiB 944.49 KiB
670b474 23.75 KiB 974.89 KiB 951.14 KiB

Previous results on branch: itay/add_sentry_size_analysis

Startup times

Revision Plain With Sentry Diff
aca0ee1 1194.73 ms 1215.72 ms 20.99 ms
3a28fd5 1194.49 ms 1217.15 ms 22.66 ms

App size

Revision Plain With Sentry Diff
aca0ee1 24.15 KiB 1.01 MiB 1012.18 KiB
3a28fd5 24.14 KiB 1.01 MiB 1012.19 KiB

@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@aa43aea). Learn more about missing BASE report.
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main     #6779   +/-   ##
========================================
  Coverage        ?   84.858%           
========================================
  Files           ?       451           
  Lines           ?     27521           
  Branches        ?     12060           
========================================
  Hits            ?     23354           
  Misses          ?      4124           
  Partials        ?        43           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa43aea...0ae351f. Read the comment docs.

@itaybre itaybre marked this pull request as ready for review November 14, 2025 18:39
@github-actions
Copy link
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

  • .github/file-filters.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Use this label to trigger all PR workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: Upload binary for size analysis

3 participants