-
-
Notifications
You must be signed in to change notification settings - Fork 372
chore: Upload binary for size analysis #6779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5c5648e | 1234.44 ms | 1253.79 ms | 19.35 ms |
| daeeb27 | 1235.35 ms | 1253.77 ms | 18.42 ms |
| 354b020 | 1223.88 ms | 1236.82 ms | 12.94 ms |
| 7629df7 | 1224.80 ms | 1250.29 ms | 25.49 ms |
| b358363 | 1228.33 ms | 1262.34 ms | 34.01 ms |
| a4e1541 | 1229.56 ms | 1264.33 ms | 34.77 ms |
| 0ee162c | 1226.90 ms | 1261.72 ms | 34.83 ms |
| 2675d3c | 1218.94 ms | 1239.36 ms | 20.42 ms |
| a598105 | 1236.51 ms | 1258.88 ms | 22.37 ms |
| 670b474 | 1225.33 ms | 1259.59 ms | 34.26 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5c5648e | 23.75 KiB | 879.60 KiB | 855.86 KiB |
| daeeb27 | 23.75 KiB | 989.12 KiB | 965.37 KiB |
| 354b020 | 23.75 KiB | 878.19 KiB | 854.44 KiB |
| 7629df7 | 23.75 KiB | 959.45 KiB | 935.70 KiB |
| b358363 | 23.75 KiB | 987.92 KiB | 964.18 KiB |
| a4e1541 | 23.75 KiB | 1023.82 KiB | 1000.07 KiB |
| 0ee162c | 23.75 KiB | 933.33 KiB | 909.58 KiB |
| 2675d3c | 23.75 KiB | 928.16 KiB | 904.41 KiB |
| a598105 | 23.75 KiB | 968.24 KiB | 944.49 KiB |
| 670b474 | 23.75 KiB | 974.89 KiB | 951.14 KiB |
Previous results on branch: itay/add_sentry_size_analysis
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| aca0ee1 | 1194.73 ms | 1215.72 ms | 20.99 ms |
| 3a28fd5 | 1194.49 ms | 1217.15 ms | 22.66 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| aca0ee1 | 24.15 KiB | 1.01 MiB | 1012.18 KiB |
| 3a28fd5 | 24.14 KiB | 1.01 MiB | 1012.19 KiB |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6779 +/- ##
========================================
Coverage ? 84.858%
========================================
Files ? 451
Lines ? 27521
Branches ? 12060
========================================
Hits ? 23354
Misses ? 4124
Partials ? 43 Continue to review full report in Codecov by Sentry.
|
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
Uploads an example binary for size analysis
Created a new SDK-Size target so we have a clean binary without other stuff included and better represent our SDK size.
This is why I am using Sentry as static too
Closes #6783