-
-
Notifications
You must be signed in to change notification settings - Fork 372
chore: Avoid resolving SPM dependencies for Benchmarking app #6818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6818 +/- ##
=============================================
+ Coverage 7.086% 84.856% +77.769%
=============================================
Files 418 453 +35
Lines 26346 27609 +1263
Branches 9862 12102 +2240
=============================================
+ Hits 1867 23428 +21561
+ Misses 24466 3896 -20570
- Partials 13 285 +272 see 434 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ee1f2ca | 1227.47 ms | 1251.58 ms | 24.12 ms |
| 0759f32 | 1237.10 ms | 1257.35 ms | 20.25 ms |
| 11853e6 | 1220.37 ms | 1252.83 ms | 32.46 ms |
| c6c1cb7 | 1235.71 ms | 1263.80 ms | 28.08 ms |
| 7bd90de | 1233.48 ms | 1249.47 ms | 15.99 ms |
| b9ceffb | 1222.57 ms | 1247.96 ms | 25.39 ms |
| 2fc1ea5 | 1236.23 ms | 1246.79 ms | 10.56 ms |
| 837f5e4 | 1231.20 ms | 1265.47 ms | 34.27 ms |
| cd9727b | 1236.04 ms | 1254.41 ms | 18.37 ms |
| debf3e9 | 1227.45 ms | 1235.71 ms | 8.26 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ee1f2ca | 24.15 KiB | 1.01 MiB | 1015.24 KiB |
| 0759f32 | 23.75 KiB | 880.20 KiB | 856.46 KiB |
| 11853e6 | 23.75 KiB | 1.01 MiB | 1016.04 KiB |
| c6c1cb7 | 23.75 KiB | 928.15 KiB | 904.40 KiB |
| 7bd90de | 23.75 KiB | 933.33 KiB | 909.58 KiB |
| b9ceffb | 23.75 KiB | 969.07 KiB | 945.32 KiB |
| 2fc1ea5 | 23.75 KiB | 1.02 MiB | 1016.53 KiB |
| 837f5e4 | 23.75 KiB | 1.01 MiB | 1016.25 KiB |
| cd9727b | 23.75 KiB | 879.25 KiB | 855.51 KiB |
| debf3e9 | 23.75 KiB | 1.01 MiB | 1006.46 KiB |
philipphofmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Because we now have some dependencies to
sentry-cocoaSPM version on the workspace, Xcode will try to download sentry-cocoa on CI even when not needed.Using the project instead of the workspace will let us skip that dependencies resolution.
#skip-changelog
Closes #6819