Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v9]: Replace custom Platform & PlatformChecker with package platform #2729

Draft
wants to merge 3 commits into
base: v9
Choose a base branch
from

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Feb 18, 2025

📜 Description

Replace Platform

💡 Motivation and Context

Relates to #2646

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Replace custom Platform & PlatformChecker with package platform ([#2729](https://github.com/getsentry/sentry-dart/pull/2729))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against b80690d

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.12%. Comparing base (75e3eba) to head (b80690d).
Report is 1 commits behind head on v9.

Additional details and impacted files
@@            Coverage Diff             @@
##               v9    #2729      +/-   ##
==========================================
- Coverage   88.50%   87.12%   -1.38%     
==========================================
  Files         262      121     -141     
  Lines        8758     4172    -4586     
==========================================
- Hits         7751     3635    -4116     
+ Misses       1007      537     -470     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant