Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cleanup platform mocking #2730

Open
wants to merge 11 commits into
base: v9
Choose a base branch
from

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Feb 18, 2025

  • refactor: cleanup platform mocking

📜 Description

part of #2646

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 5 lines in your changes missing coverage. Please review.

Project coverage is 87.21%. Comparing base (0f8bd48) to head (8411978).

Files with missing lines Patch % Lines
dart/lib/src/platform/_io_platform.dart 72.72% 3 Missing ⚠️
dart/lib/src/platform/platform.dart 83.33% 1 Missing ⚠️
dart/lib/src/platform_checker.dart 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v9    #2730      +/-   ##
==========================================
+ Coverage   87.16%   87.21%   +0.05%     
==========================================
  Files         175      176       +1     
  Lines        5966     5985      +19     
==========================================
+ Hits         5200     5220      +20     
+ Misses        766      765       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@getsentry getsentry deleted a comment from github-actions bot Feb 18, 2025
Copy link
Contributor

github-actions bot commented Feb 18, 2025

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- cleanup platform mocking ([#2730](https://github.com/getsentry/sentry-dart/pull/2730))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 8411978

@ueman
Copy link
Collaborator

ueman commented Feb 18, 2025

Isn't the platform checker used to decide which native integration is called? So actually returning true for 'isMacOs' on web would cause the macos integrations to be called on web?

@vaind
Copy link
Collaborator Author

vaind commented Feb 19, 2025

Isn't the platform checker used to decide which native integration is called? So actually returning true for 'isMacOs' on web would cause the macos integrations to be called on web?

I believe that was the case in the past but looking at how the code which calls hasNativeIntegration has evolved, it seems pretty useless now. Also, it's actually always true for the platforms we support:

  bool get hasNativeIntegration =>
      platform.isWeb ||
      platform.isAndroid ||
      platform.isIOS ||
      platform.isMacOS ||
      platform.isWindows ||
      platform.isLinux;
      ```

@vaind vaind marked this pull request as ready for review February 19, 2025 10:52
@vaind vaind marked this pull request as draft February 19, 2025 10:52
@vaind vaind changed the title refactor/cleanup platform mocking refactor: cleanup platform mocking Feb 19, 2025
@vaind
Copy link
Collaborator Author

vaind commented Feb 19, 2025

Error: A value of type 'SentryTransaction Function(SentryTransaction)' can't be assigned to a variable of type 'FutureOr<SentryTransaction?> Function(SentryTransaction, Hint)?'.
 - 'SentryTransaction' is from 'package:sentry/src/protocol/sentry_transaction.dart' ('../dart/lib/src/protocol/sentry_transaction.dart').
 - 'Hint' is from 'package:sentry/src/hint.dart' ('../dart/lib/src/hint.dart').
      fixture.options.beforeSendTransaction = (transaction) {
                                              ^
Shuffling test order with --test-randomize-ordering-seed=3637785904

doesn't seem related to the changes in this PR

@buenaflor
Copy link
Contributor

we recently added hints to transactions, looks like flutter tests weren't updated

cc @denrase

@vaind vaind marked this pull request as ready for review February 19, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants