-
-
Notifications
You must be signed in to change notification settings - Fork 266
enh: use lifecycle hook for before send event #3017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
enh: use lifecycle hook for before send event #3017
Conversation
…m:getsentry/sentry-dart into feat/add-os-and-device-attributes-to-logs
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- use lifecycle hook for before send event ([#3017](https://github.com/getsentry/sentry-dart/pull/3017)) If none of the above apply, you can opt out of this check by adding |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3017 +/- ##
==========================================
- Coverage 87.97% 87.87% -0.11%
==========================================
Files 287 287
Lines 9533 9541 +8
==========================================
- Hits 8387 8384 -3
- Misses 1146 1157 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
iOS Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
827bf09 | 1261.86 ms | 1276.41 ms | 14.55 ms |
c8596a6 | 1234.11 ms | 1241.19 ms | 7.08 ms |
73dca78 | 1246.65 ms | 1265.42 ms | 18.76 ms |
93b7728 | 1247.23 ms | 1264.87 ms | 17.64 ms |
b6c8720 | 1252.65 ms | 1266.61 ms | 13.96 ms |
2d34233 | 1258.19 ms | 1268.92 ms | 10.73 ms |
6ba4675 | 1223.12 ms | 1238.17 ms | 15.04 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
827bf09 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
c8596a6 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
73dca78 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
93b7728 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
b6c8720 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
2d34233 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
6ba4675 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
Previous results on branch: enhancements/use-lifecycle-hook-before-send-event
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
9d51684 | 1245.62 ms | 1249.02 ms | 3.40 ms |
4e720b9 | 1265.15 ms | 1272.98 ms | 7.83 ms |
e052838 | 1254.76 ms | 1263.79 ms | 9.04 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
9d51684 | 7.85 MiB | 9.45 MiB | 1.59 MiB |
4e720b9 | 7.85 MiB | 9.45 MiB | 1.59 MiB |
e052838 | 7.85 MiB | 9.45 MiB | 1.59 MiB |
Android Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
6ba4675 | 499.80 ms | 632.43 ms | 132.63 ms |
2d34233 | 470.54 ms | 558.90 ms | 88.36 ms |
73dca78 | 476.53 ms | 522.21 ms | 45.68 ms |
b6c8720 | 457.41 ms | 519.04 ms | 61.63 ms |
93b7728 | 475.28 ms | 489.13 ms | 13.86 ms |
c8596a6 | 474.00 ms | 492.96 ms | 18.96 ms |
827bf09 | 475.40 ms | 547.14 ms | 71.74 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
6ba4675 | 6.54 MiB | 7.53 MiB | 1015.26 KiB |
2d34233 | 6.54 MiB | 7.55 MiB | 1.01 MiB |
73dca78 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
b6c8720 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
93b7728 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
c8596a6 | 6.54 MiB | 7.53 MiB | 1015.27 KiB |
827bf09 | 6.54 MiB | 7.53 MiB | 1015.27 KiB |
Previous results on branch: enhancements/use-lifecycle-hook-before-send-event
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
9d51684 | 517.34 ms | 569.74 ms | 52.40 ms |
4e720b9 | 469.48 ms | 517.15 ms | 47.67 ms |
e052838 | 457.27 ms | 485.24 ms | 27.97 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
9d51684 | 6.54 MiB | 7.53 MiB | 1017.60 KiB |
4e720b9 | 6.54 MiB | 7.53 MiB | 1017.60 KiB |
e052838 | 6.54 MiB | 7.53 MiB | 1017.60 KiB |
@denrase can you have a early look pls |
📜 Description
Now that we have sdk lifecycle hooks we can re-factor the beforeSendEvent observer that we added to implement web sessions
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps