(DRAFT) enh: refactor init to use JNI/FFI
#3324
Conversation
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Features
- refactor `init` to use JNI/FFI ([#3324](https://github.com/getsentry/sentry-dart/pull/3324))If none of the above apply, you can opt out of this check by adding |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| package io.sentry.flutter | ||
|
|
||
| interface ReplayRecorderCallbacks { | ||
| fun replayStarted(replayId: String, replayIsBuffering: Boolean) |
There was a problem hiding this comment.
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected after opening parenthesis
| package io.sentry.flutter | ||
|
|
||
| interface ReplayRecorderCallbacks { | ||
| fun replayStarted(replayId: String, replayIsBuffering: Boolean) |
There was a problem hiding this comment.
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Parameter should start on a newline
| package io.sentry.flutter | ||
|
|
||
| interface ReplayRecorderCallbacks { | ||
| fun replayStarted(replayId: String, replayIsBuffering: Boolean) |
There was a problem hiding this comment.
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected before closing parenthesis
|
|
||
| interface ReplayRecorderCallbacks { | ||
| fun replayStarted(replayId: String, replayIsBuffering: Boolean) | ||
| fun replayResumed() |
There was a problem hiding this comment.
🚫 [ktlint] standard:blank-line-before-declaration reported by reviewdog 🐶
Expected a blank line for this declaration
| interface ReplayRecorderCallbacks { | ||
| fun replayStarted(replayId: String, replayIsBuffering: Boolean) | ||
| fun replayResumed() | ||
| fun replayPaused() |
There was a problem hiding this comment.
🚫 [ktlint] standard:blank-line-before-declaration reported by reviewdog 🐶
Expected a blank line for this declaration
| } | ||
|
|
||
| @JvmStatic | ||
| fun setupReplayJni(options: SentryAndroidOptions, replayCallbacks: ReplayRecorderCallbacks?) { |
There was a problem hiding this comment.
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected after opening parenthesis
| } | ||
|
|
||
| @JvmStatic | ||
| fun setupReplayJni(options: SentryAndroidOptions, replayCallbacks: ReplayRecorderCallbacks?) { |
There was a problem hiding this comment.
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Parameter should start on a newline
| } | ||
|
|
||
| @JvmStatic | ||
| fun setupReplayJni(options: SentryAndroidOptions, replayCallbacks: ReplayRecorderCallbacks?) { |
There was a problem hiding this comment.
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected before closing parenthesis
| @@ -0,0 +1,92 @@ | |||
| package io.sentry.flutter | |||
|
|
|||
| import android.os.Handler | |||
There was a problem hiding this comment.
🚫 [ktlint] standard:import-ordering reported by reviewdog 🐶
Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end
| } | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
🚫 [ktlint] standard:no-consecutive-blank-lines reported by reviewdog 🐶
Needless blank line(s)
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0fb45d0 | 1273.24 ms | 1286.44 ms | 13.19 ms |
| c8596a6 | 1234.11 ms | 1241.19 ms | 7.08 ms |
| aeb02f2 | 1244.29 ms | 1256.55 ms | 12.26 ms |
| 5a95d04 | 1263.17 ms | 1265.37 ms | 2.20 ms |
| e2d675d | 1238.48 ms | 1242.76 ms | 4.28 ms |
| 9b99523 | 1256.06 ms | 1270.33 ms | 14.27 ms |
| 8541716 | 1270.18 ms | 1271.80 ms | 1.62 ms |
| de377fd | 1252.28 ms | 1254.76 ms | 2.48 ms |
| 2cf9161 | 1248.33 ms | 1266.55 ms | 18.22 ms |
| 5b9a0da | 1249.69 ms | 1250.71 ms | 1.03 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0fb45d0 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| c8596a6 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| aeb02f2 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 5a95d04 | 5.53 MiB | 6.01 MiB | 487.81 KiB |
| e2d675d | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 9b99523 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 8541716 | 5.53 MiB | 6.00 MiB | 479.96 KiB |
| de377fd | 20.71 MiB | 22.43 MiB | 1.73 MiB |
| 2cf9161 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 5b9a0da | 5.53 MiB | 5.96 MiB | 444.32 KiB |
📜 Description
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps