Skip to content

Conversation

@tsinis
Copy link

@tsinis tsinis commented May 6, 2025

Description

PR resolves an issue: getsentry/sentry-dart#2912 (review)

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@vercel
Copy link

vercel bot commented May 6, 2025

@tsinis is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented May 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2025 8:13pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview May 7, 2025 8:13pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview May 7, 2025 8:13pm

@buenaflor
Copy link
Contributor

Made some modifications if you don't mind :)

@coolguyzone can be reviewed now

@buenaflor buenaflor requested a review from coolguyzone May 7, 2025 11:25
Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a suggestion, looks good to me! Thanks for contributing 🏄‍♂️

@tsinis
Copy link
Author

tsinis commented Aug 13, 2025

Noticed another thing in the docs today - asynchronous Sentry.captureMessage("My message"); call isn't awaited in the current docs, but being suggested to pass into the associatedEventId param, which expects SentryId?, not Future< SentryId?>. If you prefer me to do it in a separate PR, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants