Skip to content

Ref(capacitor): source maps update #14486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

lucas-zimerman
Copy link
Collaborator

@lucas-zimerman lucas-zimerman commented Jul 29, 2025

DESCRIBE YOUR PR

Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.

This PR updates Capacitor source maps upload.

There is now an explanation on how to send source maps based on how users build their app.

  • Ionic Capacitor Build: This method has no hooks so we need to modify the source files after they get uploaded to the native bundle.
  • Ionic Build: Follows the original method of uploading source maps

Additionally, the getting started adds the suggestion to remove the source maps files after uploaded and instruct the debug ID injection that previously was missing.

Review Help:

  • uploading/ionic.mdx: It's just the file uploading/typescript.mdx with minor renames of typescript to Ionic.
  • uploading/ionic-capacitor.mdx: Follows the same idea, but with additional code snippets since the file paths are different and you need to uplaod twice.

This PR will fix the following issue getsentry/sentry-capacitor#643, getsentry/sentry-capacitor#481 and getsentry/sentry-capacitor#455

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

EXTRA RESOURCES

Copy link

vercel bot commented Jul 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2025 10:24pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2025 10:24pm

Copy link

codecov bot commented Jul 29, 2025

Bundle Report

Changes will increase total bundle size by 909 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 9.85MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.27MB 915 bytes (0.01%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%
../app/[[...path]]/page.js.nft.json 308 bytes 731.99kB 0.04%
../app/platform-redirect/page.js.nft.json 308 bytes 731.9kB 0.04%
../app/sitemap.xml/route.js.nft.json 308 bytes 729.38kB 0.04%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 879.71kB -0.0%
static/chunks/1831-*.js -3 bytes 422.23kB -0.0%
static/3Ig0Zgpsqsw9yvwux7iLp/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/3Ig0Zgpsqsw9yvwux7iLp/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/MQ9K0TYTTpOH-*.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/MQ9K0TYTTpOH-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

@lucas-zimerman
Copy link
Collaborator Author

Not sure what's the Vercel issue but I can deploy it locally

Copy link
Collaborator

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Not sure what's the Vercel issue but I can deploy it locally

I don't have access to check this but I see this seems to fail on main too

@coolguyzone coolguyzone requested a review from chargome July 29, 2025 20:16
@coolguyzone
Copy link
Contributor

@lucas-zimerman Try rebasing from the latest master, I think it may have been in a bad state when you last pulled.

@codeowner-assignment codeowner-assignment bot requested review from a team July 29, 2025 21:48
cursor[bot]

This comment was marked as outdated.

@lucas-zimerman
Copy link
Collaborator Author

@lucas-zimerman Try rebasing from the latest master, I think it may have been in a bad state when you last pulled.

Indeed something was off, had to reset the branch and cherry-pick my commit in order to fix it,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants