-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Ref(capacitor): source maps update #14486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 909 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
Not sure what's the Vercel issue but I can deploy it locally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Not sure what's the Vercel issue but I can deploy it locally
I don't have access to check this but I see this seems to fail on main too
@lucas-zimerman Try rebasing from the latest master, I think it may have been in a bad state when you last pulled. |
52c0f76
to
1d037df
Compare
Indeed something was off, had to reset the branch and cherry-pick my commit in order to fix it, |
DESCRIBE YOUR PR
Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.
This PR updates Capacitor source maps upload.
There is now an explanation on how to send source maps based on how users build their app.
Additionally, the getting started adds the suggestion to remove the source maps files after uploaded and instruct the debug ID injection that previously was missing.
Review Help:
uploading/typescript.mdx
with minor renames of typescript to Ionic.This PR will fix the following issue getsentry/sentry-capacitor#643, getsentry/sentry-capacitor#481 and getsentry/sentry-capacitor#455
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
EXTRA RESOURCES