-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Updated dotnet options to include all defaults #15218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
@bitsandfoxes - I made some guesses and approximations to defaults based on other SDKs. Please correct where it's wrong. Thanks! ❓ |
Bundle ReportChanges will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
<PlatformSection supported={["dotnet.xamarin"]}> | ||
|
||
<SdkOption name="ScreenshotQuality" type="enum"> | ||
<SdkOption name="ScreenshotQuality" type="enum" defaultValue="high"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This must have slipped through, I can't find ScreenshotQuality
in neither the .NET SDK nor its Xamarin flavor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ScreenshotQuality
is weird. It seems like there are mentions of it in this sentry-xamarin
pull request: getsentry/sentry-xamarin#76 (comment)
But Don't see it mentioned anywhere in the code itself...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm. Sounds like maybe we remove it then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say yes, @bitsandfoxes Should we remove this?
Co-authored-by: Stefan Jandl <[email protected]>
DESCRIBE YOUR PR
Updated options with defaults based on move to SDKoption formatting.
Preview: https://sentry-docs-git-dotnet-options-updates.sentry.dev/platforms/dotnet/configuration/options/
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES