Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(Capacitor): Source map docs #9437

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lucas-zimerman
Copy link
Collaborator

Pre-merge checklist

If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs
  • PR was reviewed and approved by a member of the Sentry docs team

Description of changes

This PR reuses the JavaScript source map page layout, adding an additional sample on which platform/tool to select when users are using the script ionic build to build their projects.

Extra resources

Copy link

vercel bot commented Mar 13, 2024

@lucas-zimerman is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Mar 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2024 3:54pm


```example
◆ Which framework, bundler or build tool are you using?
│ ● Angular
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why some frameworks have a solid circle (angular) vs an open one (next.js)? It's confusing because the solid ones feel like it's selected


If you want to configure source maps upload manually, follow the guide for your bundler or build tool below.

### Sentry Bundler Supporte
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Sentry Bundler Supporte
### Sentry Bundler Support

If your project uses `Ionic build` for building your project, select the `tsc` option.
</Note>

## Manual Source Maps upload
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Manual Source Maps upload
## Manual Source Maps Upload


<Include name="sourcemaps-wizard-instructions.mdx" />

After choosing your Sentry project, the setup process will prompt you to select a framework. This step is crucial for configuring Sentry correctly. Make sure to choose the appropriate framework based on your project’s requirements.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this guide is specifically for capacitor, can we provide more explicit instructions on what users should select?

@krystofwoldrich
Copy link
Member

@lucas-zimerman Do I understand the changes correctly, that the source maps setup is the same as for web applications?

We can link the frameworks pages on the capacitor page if there is no difference.

https://docs.sentry.io/platforms/javascript/guides/angular/sourcemaps/uploading/angular-webpack/
https://docs.sentry.io/platforms/javascript/guides/react/sourcemaps/uploading/create-react-app/
...

@getsantry
Copy link
Contributor

getsantry bot commented Apr 5, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Apr 5, 2024
@getsantry getsantry bot closed this Apr 13, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2024
@krystofwoldrich
Copy link
Member

I'm reopening this as we still want to add these docs.

@krystofwoldrich
Copy link
Member

I was expecting the capacitor docs describe how to export and upload source maps.

Maybe reference https://ionicframework.com/docs/cli/commands/build#advanced-options and ionic build --source-maps

@getsantry getsantry bot removed the Stale label Dec 4, 2024
@getsantry getsantry bot added Stale and removed Stale labels Dec 26, 2024
@getsantry getsantry bot added Stale and removed Stale labels Jan 18, 2025
@getsantry getsantry bot added Stale and removed Stale labels Feb 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants