-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update(Capacitor): Source map docs #9437
base: master
Are you sure you want to change the base?
Conversation
@lucas-zimerman is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
||
```example | ||
◆ Which framework, bundler or build tool are you using? | ||
│ ● Angular |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why some frameworks have a solid circle (angular) vs an open one (next.js)? It's confusing because the solid ones feel like it's selected
|
||
If you want to configure source maps upload manually, follow the guide for your bundler or build tool below. | ||
|
||
### Sentry Bundler Supporte |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### Sentry Bundler Supporte | |
### Sentry Bundler Support |
If your project uses `Ionic build` for building your project, select the `tsc` option. | ||
</Note> | ||
|
||
## Manual Source Maps upload |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## Manual Source Maps upload | |
## Manual Source Maps Upload |
|
||
<Include name="sourcemaps-wizard-instructions.mdx" /> | ||
|
||
After choosing your Sentry project, the setup process will prompt you to select a framework. This step is crucial for configuring Sentry correctly. Make sure to choose the appropriate framework based on your project’s requirements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this guide is specifically for capacitor, can we provide more explicit instructions on what users should select?
@lucas-zimerman Do I understand the changes correctly, that the source maps setup is the same as for web applications? We can link the frameworks pages on the capacitor page if there is no difference. https://docs.sentry.io/platforms/javascript/guides/angular/sourcemaps/uploading/angular-webpack/ |
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
I'm reopening this as we still want to add these docs. |
I was expecting the capacitor docs describe how to export and upload source maps. Maybe reference https://ionicframework.com/docs/cli/commands/build#advanced-options and |
Pre-merge checklist
If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.
Description of changes
This PR reuses the JavaScript source map page layout, adding an additional sample on which platform/tool to select when users are using the script
ionic build
to build their projects.Extra resources
Closes #455