chore: profiling improvements #3941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaind
changed the title
vaind
force-pushed
the
feat/profling-improvements
branch
from
a2b3664 to
f89815a
Compare
@vaind any idea how/why the same method ends up with multiple frames on the stack? That implies the method actually gets called twice right (unless one of them is a wrapper)? |
jamescrosswell
approved these changes
Feb 7, 2025
Not on the same stack. |
3 tasks
jamescrosswell
added a commit
that referenced
this pull request
Feb 13, 2025
* Revert "Skip flaky test (EventPipeSession_ReceivesExpectedCLREvents) (#3949)" This reverts commit 50e5232. * Revert "fix: net8 unknown stack trace methods for JIT methods (#3942)" This reverts commit d197cb2. * Revert "chore: profiling improvements (#3941)" This reverts commit bea672a. * chore: revert changelog * Verify tests * Windows verify tests --------- Co-authored-by: James Crosswell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some improvements I've done while investigating #3924 - the only visible thing is deduplicating stack frames that do have a different code address but are actually the same method so as far as the UI is concerned, they're the same frame.